<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116069/">https://git.reviewboard.kde.org/r/116069/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation and KDE Frameworks.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Feb. 27, 2014, 10:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- remove compatibility variables as in the parent RR
PING: any feedback? I would like to push this into alpha2.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- If this patch is applied, once kde4support is *installed* (no explicit dependency is needed), other modules can use the old DTD. Of course it's better to port them to the new one.
- Please note that some files should be copied with complete history from the corresponding files in kdoctools before the changes of RR116068:
cmake/FindDocBookXML4.cmake (copied and unchanged)
src/customization/catalog4.xml (from catalog.xml, then modified)
src/customization/dtd/kdex.dtd.cmake (copied and unchanged)
- this patch includes also the commit which bumps the included documentation to 4.5 (needed in order to test this patch and RR116068).
This RR comprises the steps 2), 3b) and (limited to the current module) 3c) of the plan described here:
http://mail.kde.org/pipermail/kde-frameworks-devel/2014-February/011978.html</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compilation of kde4support (with RR116068), then compilation of konsole.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindDocBookXML4.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kf5-config/man-kf5-config.1.docbook <span style="color: grey">(ae567bf)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6bda099)</span></li>
<li>src/customization/catalog4.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/customization/dtd/kdex.dtd.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116069/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>