<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116014/">https://git.reviewboard.kde.org/r/116014/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 25th, 2014, 11:46 a.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generally looks good, but I'm wondering about the WIN32 clause. EGL is really just an API, right? What we're really searching for is the Mesa implementation. I guess that other platforms may well have their own implementations that, long term, it would be nice for this file to look for. In the meantime, it probably makes sense to print a message on WIN32 about how we're not looking for anything. Some of the stuff should then go outside the WIN32 clause, like find_package_handle_standard_args and set_package_properties.
Also: what about APPLE? Does that use Mesa?
Also: capitalisation. Shouldn't it be EGL, rather than Egl?</pre>
</blockquote>
<p>On February 25th, 2014, 12:01 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">egl should only be relevant to Unix systems. Traditionally we had:
* GLX for X11
* CGL for Mac
* WGL for Windows
* EGL for Embedded
That egl can also be used as a replacement for GLX is rather new (e.g. latest NVIDIA driver) and I think that only holds for the unix systems so on other platforms the respective native APIs should be used, but I honestly don't know. Also we are not really searching for the Mesa implementation. We are searching for any implementation, though on Linux that would normally be the Mesa implementation which provides the pkg config file. I don't know how that is when one installs the NVIDIA driver, though. AFAIK there are plans to standardize this and have a generic provider for everything OpenGL related.
Concerning capitalisation: I don't know, on Khronos it seems to be EGL, so I'll change.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't really know much about EGL as such. I'm going off how the FindOpenGL.cmake file shipped with CMake works.
At the very least, on WIN32, it should print a message and set EGL_FOUND to false. And the package properties should be set outside the if(WIN32) block.</pre>
<br />
<p>- Alex</p>
<br />
<p>On February 25th, 2014, 12:02 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Alex Merry.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 12:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a FindEgl module
This module finds the egl library through pkg-config.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adjusted KWin to find egl through this cmake module. Picks up egl, compiles and links.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/FindEgl.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116014/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>