<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116030/">https://git.reviewboard.kde.org/r/116030/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Chusslove Illich.</div>
<div>By Kevin Krammer.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2014, 4:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added function to remove test config after test and call it from cleanupTestCase.
Renamed new config file to ktranscript.ini, should fit better in cross-platform world</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Write a test config to a test location using QStandardPath's test feature.
Test getConf... calls in success and fallback mode.
Actually found a missing bool -> script bool conversion. fixed
Chusslove: how about using ktranscript.ini for the file to look up using QStandardPaths? Maybe a more obvious on other platforms?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All previously existing tests continue to run :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(6e926ba)</span></li>
<li>autotests/ktranscripttest.h <span style="color: grey">(7ea7818)</span></li>
<li>autotests/ktranscripttest.cpp <span style="color: grey">(e3a27ff)</span></li>
<li>autotests/test.js <span style="color: grey">(ad53b1b)</span></li>
<li>autotests/testhelpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/testhelpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ktranscript.cpp <span style="color: grey">(44c8b63)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116030/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>