<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115983/">https://git.reviewboard.kde.org/r/115983/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b0a60d0feb2dcac7af5f921be830bc4d9b9d3d18 by Kevin Krammer to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 23rd, 2014, 9:52 p.m. UTC, Kevin Krammer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Chusslove Illich.</div>
<div>By Kevin Krammer.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2014, 9:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create the script engine as a QObject child of the interface and
delete all interfaces in KTranscriptImp's destructor.
valgrind --tool=memcheck ./ktranscripttest
before:
==10664== HEAP SUMMARY:
==10664== in use at exit: 445,913 bytes in 2,753 blocks
==10664== total heap usage: 27,995 allocs, 25,242 frees, 6,059,328 bytes allocated
==10664==
==10664== LEAK SUMMARY:
==10664== definitely lost: 0 bytes in 0 blocks
==10664== indirectly lost: 0 bytes in 0 blocks
==10664== possibly lost: 1,488 bytes in 3 blocks
==10664== still reachable: 444,425 bytes in 2,750 blocks
==10664== suppressed: 0 bytes in 0 blocks
after:
==11788== HEAP SUMMARY:
==11788== in use at exit: 13,778 bytes in 66 blocks
==11788== total heap usage: 28,003 allocs, 27,937 frees, 6,064,040 bytes allocated
==11788==
==11788== LEAK SUMMARY:
==11788== definitely lost: 0 bytes in 0 blocks
==11788== indirectly lost: 0 bytes in 0 blocks
==11788== possibly lost: 1,488 bytes in 3 blocks
==11788== still reachable: 12,290 bytes in 63 blocks
==11788== suppressed: 0 bytes in 0 blocks
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All tests still run successfully</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ktranscript.cpp <span style="color: grey">(1ce0d1a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115983/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>