<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115936/">https://git.reviewboard.kde.org/r/115936/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Chusslove Illich</p>
<br />
<p>On February 22nd, 2014, 2:42 p.m. CET, Kevin Krammer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Chusslove Illich.</div>
<div>By Kevin Krammer.</div>
<p style="color: grey;"><i>Updated Feb. 22, 2014, 2:42 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Separate ktranscript plugin test into its own autotest
The plugin based test of KTranscript performs all tests with a single
instance of KTranscriptImp because the plugin uses Q_GLOBAL_STATIC
to create and access that instance.
The non-plugin test creates a new instance for every test.
Currently all scripting tests are runnable in both situations, but the
non-plugin test allows for tests that need a "clean slate".
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All three tests run without failure</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(eb73d21)</span></li>
<li>autotests/ktranscriptcleantest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/ktranscriptcleantest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/ktranscripttest.h <span style="color: grey">(53f3ce0)</span></li>
<li>autotests/ktranscripttest.cpp <span style="color: grey">(78aecb4)</span></li>
<li>src/ktranscript.cpp <span style="color: grey">(c922e91)</span></li>
<li>src/ktranscript_p.h <span style="color: grey">(f1cc132)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115936/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>