<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115774/">https://git.reviewboard.kde.org/r/115774/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 16th, 2014, 11:40 a.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One thing worth considering as part of this is whether extra integration classes should get their own libraries or be put in the same one as KStyle. If the latter, we probably want to rename KF5::Style.</pre>
</blockquote>
<p>On February 16th, 2014, 11:45 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The kstyle lib is for KStyle (which only widget styles link to), so I think other integration bits, if any come up, will become different libs.
(unlikely, even, since libs that apps should link to, don't belong in tier4).
So I think KF5::Style is fine.
</pre>
</blockquote>
<p>On February 16th, 2014, 12:12 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That, of course, means we're getting styles to find_package(KF5FrameworkIntegration) to use KF5::Style which ends up being a little surprising. At least with KIO, it's fairly clear where KF5::KIOCore and KF5::KIOWidgets come from.
I can sort of see the advantage of having a FrameworkIntegration config file, if only to allow for a RUNTIME dependency for workspace, but it would be nice to also allow find_package(KF5Style) like before. Possibly by installing a KF5StyleConfig.cmake file as before, and having KF5FrameworkIntegration list that as a dep.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think "couldn't find package frameworkintegration" is a clearer error message than "couldn't find package kstyle", when there is no kstyle framework.
That's from the user point of view.
>From the developer point of view, you're right, it's not obvious that you have to find_package(FrameworkIntegration) to get KF5::Style. But developers can dig a little bit more :-)
In any case my main goal is consistency with the other frameworks, for ease of maintainance, which also pushes towards find_package(frameworkintegration) as in this commit.</pre>
<br />
<p>- David</p>
<br />
<p>On February 16th, 2014, 11:31 a.m. UTC, David Faure wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2014, 11:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove code that allows KStyle to build standalone
This is just excess maintenance burden for no real gain.
This commit includes RR 115700 by Michael Palimaka:
guiaddons and itemviews doesn't appear to be used anywhere, so remove it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0d9551031037a0c33a5ea73a05151491d698235b)</span></li>
<li>src/kstyle/CMakeLists.txt <span style="color: grey">(f1379c852005c816dc80da4717ffb113d5a0d0a0)</span></li>
<li>src/kstyle/KF5StyleConfig.cmake.in <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115774/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>