<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115355/">https://git.reviewboard.kde.org/r/115355/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115355/diff/3/?file=243473#file243473line1" style="color: black; font-weight: bold; text-decoration: underline;">cmake/FindSharedMimeInfo.cmake</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># Try to find the shared-mime-info package</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This file is also needed by kcoreaddons (and I would also need it for okteta, currently the mimetype subdir is commented out).
I think it would make more sense to have this in extra-cmake-modules.</pre>
</div>
<br />
<p>- Alexander Richardson</p>
<br />
<p>On February 12th, 2014, 12:03 p.m. CET, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2014, 12:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make WebP mimetype xml match the one in shared-mime-info-git
This includes the detection magic and an alias for image/webp. It
should be in shared-mime-info 1.3.
Proposed by Jerome Leclanche <adys.wh@gmail.com>.
Import the WebP image I/O code from kde-runtime
The plugin export mechanism has been patched up (including the addition
of the JSON file), and the FindWebP.cmake file is new.
Writing is currently disabled, as it produces broken images.
Autotests are generated using the cwebp and dwebp utilities distributed
with the libwebp reference library.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles; installs; the imageconverter test utility manages to convert from webp fine (PNG results checked in Gwenview from KDE4).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindWebP.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/CMakeLists.txt <span style="color: grey">(242753e0b2c493bbf1da9654967494415e8249d8)</span></li>
<li>src/imageformats/webp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/webp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/webp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/webp.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imageformats/webp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(0192636c3617bf37264a3895e61ecd837e228c4a)</span></li>
<li>autotests/read/webp/bw-cwebp-lossless.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/bw-cwebp-lossless.webp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/bw-cwebp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/bw-cwebp.webp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp-lossless.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp-lossless.webp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/webp/rgb-cwebp.webp <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/FindSharedMimeInfo.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115355/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>