<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115495/">https://git.reviewboard.kde.org/r/115495/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit fb8f12a923165a0721b5b027ae6ca65fe4bf4ce2 by Aurélien Gâteau to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 6th, 2014, 2:05 p.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Aurélien Gâteau.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Feb. 6, 2014, 2:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapidox
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This big patch moves code from depdiagram-prepare and depdiagram-generate to Python modules and make kgenframeworksapidox use those modules to generate the dependency frameworks.
This only happens when it is called with the --dependency-diagrams option.
Since the patch is going to be painful to review here, I also uploaded the patchset here: http://agateau.com/tmp/kapidox-depdiagram-integration</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generated the whole thing, works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README.md <span style="color: grey">(6a4a4a8)</span></li>
<li>docs/depdiagrams.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/depdiagram-generate <span style="color: grey">(adabe27)</span></li>
<li>src/depdiagram-prepare <span style="color: grey">(3d133d9)</span></li>
<li>src/kapidox/__init__.py <span style="color: grey">(0024723)</span></li>
<li>src/kapidox/data/dependencies.md <span style="color: grey">(5e30d09)</span></li>
<li>src/kapidox/data/dependencies.md.mustache <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kapidox/depdiagram/__init__.py <span style="color: grey">(e69de29)</span></li>
<li>src/kapidox/depdiagram/frameworkdb.py <span style="color: grey">(9b63c8b)</span></li>
<li>src/kapidox/depdiagram/generate.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kapidox/depdiagram/prepare.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kgenframeworksapidox <span style="color: grey">(ac34f2c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115495/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>