<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115649/">https://git.reviewboard.kde.org/r/115649/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On February 11th, 2014, 10:47 a.m. UTC, <b>Alex Merry</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/115649/diff/1/?file=243236#file243236line44" style="color: black; font-weight: bold; text-decoration: underline;">src/CMakeLists.txt</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kf5widgets</span> <span class="s">KF5::<span class="hl">KIOFile</span>Widgets</span><span class="hl"> </span><span class="s"><span class="hl">KF5::Plotting</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::WidgetsAddons</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::I18n</span></span> <span class="s">KF5::IconThemes</span> <span class="s">KF5::<span class="hl">Text</span>Widgets</span> <span class="s">KF5::ItemViews</span><span class="p"><span class="hl">)</span></span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">  <span class="nb">target_link_libraries</span><span class="p">(</span><span class="s">kf5widgets</span> <span class="s">KF5::<span class="hl">Completion</span></span><span class="hl"> </span><span class="s"><span class="hl">KF5::Config</span>Widgets</span> <span class="s">KF5::IconThemes</span> <span class="s">KF5::<span class="hl">KIOFile</span>Widgets</span> <span class="s">KF5::ItemViews</span></pre></td>
  </tr>

 </tbody>


 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="s">KF5::Plotting</span> <span class="s">KF5::TextWidgets</span> <span class="s">KF5::WidgetsAddons</span> <span class="s">KF5::XmlGui</span> <span class="s">KF5::Sonnet</span><span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd actually like to explicitly have KIOWidgets in this list, as there are two widgets from that library (KUrlComboRequester and KUrlRequester).</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, I have added this.</pre>
<br />




<p>- Michael</p>


<br />
<p>On February 11th, 2014, 10:22 a.m. UTC, Michael Palimaka wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Michael Palimaka.</div>


<p style="color: grey;"><i>Updated Feb. 11, 2014, 10:22 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesignerplugin
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Remove transitive dependencies
- Explicitly check for more dependencies that are required
- Do not check for KF5I18n since I cannot find anything that uses it</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. Inspected source.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(340d6d73d806e2853724960c27b9fc852e5ec2f3)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(5b796a55395578e31c7e4b70546b36b47c557823)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115649/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>