<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115613/">https://git.reviewboard.kde.org/r/115613/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 10th, 2014, 8:37 p.m. CET, <b>Dawit Alemayehu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well the platform name was added for compatibility with what Firefox at the time. And Chromium seems to have adapted that as well.
The latest stable version of Firefox (version 27) for example sends the following user agent string by default:
"Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0"
And the latest Chromium (version 32) sends the following:
"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.107 Safari/537.36"
So removing the platform name from the user-agent string might have consequences on sites that rely on it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ok, sounds like that is needed. Then we need a solution to make it work again. At all: any suggestions on how we can get the GUI platform in a core application?</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 10th, 2014, 10:15 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Dawit Alemayehu and Bernhard Beschow.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2014, 10:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Drop platform name from default user agent string
The platform name (e.g. X11) was currently broken on compile time.
On Linux it returned unknown and on all other platforms the same
name as already included in the OS name.
We cannot really determine the platform name as this is a core
application and the Qt's platform name is only available in a GUI
application. Compile time is no solution as we cannot know whether
the binary is executed on X11, Wayland, Android or whatever.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/kprotocolmanager.cpp <span style="color: grey">(f81b6797887eebd868c36b98e867eb055b05a1e2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115613/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>