<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115494/">https://git.reviewboard.kde.org/r/115494/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope, still breaks on Linux. I think it's because <cmath> undefs the signbit macro.
I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for this part of your request.</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On February 5th, 2014, 4:06 p.m. UTC, Harald Fernengel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Bernd Buschinski.</div>
<div>By Harald Fernengel.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2014, 4:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build on Mac OS X
Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so manually cast to the required type.
Also, there seems to be some magic with __signbit, it seems to be detected but then compilation fails. Prefer the suggested ::signbit() instead if available.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles again on Mac OS X :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kjs/ConfigureChecks.cmake <span style="color: grey">(473da1c)</span></li>
<li>src/kjs/global.h.cmake <span style="color: grey">(d821a72)</span></li>
<li>src/kjs/interpreter.cpp <span style="color: grey">(e699651)</span></li>
<li>src/kjs/operations.h <span style="color: grey">(a54f366)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115494/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>