<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115457/">https://git.reviewboard.kde.org/r/115457/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 01e35157eff5d45eb4a968bff71ded59e466c4ae by Alex Richardson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 4th, 2014, 3:54 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A few small commits, I only made one review request since it is only a small patch alltogether
Use the correct define _WIN32 instead of WIN32
This fixes the build with MSVC
-----------------------------
Fix MSVC linking of the test executables
-------------------------------
Fix includes on Windows
timeapi.h is needed for timeGetTime() and xmath.h no longer exists with
newer MSVC versions
------------------------------------------------------
Fix the PLATFORM(), COMPILER() etc. macros on MSVC
MSVC does not handle expanding defined() inside macros
-------------------------------------------------
Fix linkage on MSVC
We have to define MAKE_KJS_LIB to get dllimport/dllexport right
-------------------------------------------------------
Get rid of KDEWIN_INCLUDES and KDEWIN_LIBRARIES
These variables no longer exist
------------------------------------------------------------
Use ecm_mark_nongui_executable to fix linking on Windows</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(99b0c4edd1f641900527ea79b13dba230a1025e2)</span></li>
<li>tests/testkjs.cpp <span style="color: grey">(a00ed144b54896842beb9a6519d107fdff102319)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(71664cc7dd4df31ed56243440666217e1177619c)</span></li>
<li>src/wtf/Platform.h <span style="color: grey">(39e55dac1ba69feee47b8609cf05b91541f9740b)</span></li>
<li>src/wtf/MathExtras.h <span style="color: grey">(50fb006a259797b16bfce09b5e2d101cf127fb38)</span></li>
<li>src/kjs/object.h <span style="color: grey">(e2279cb026783dee1ffb2c737f6181de0f41464f)</span></li>
<li>src/kjs/function.h <span style="color: grey">(c09bd385ff2aa1dd48a80aa1032d26787514ce04)</span></li>
<li>src/kjs/CMakeLists.txt <span style="color: grey">(c1c8cef2bf1e44c8d762d6894310ce68ca05b2d7)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(1268b8a6555fd36cd73f97beb6989b21056160f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115457/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>