<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115343/">https://git.reviewboard.kde.org/r/115343/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 956bc192240b83f6856091fb69ac66ecd23dbad1 by Alex Richardson to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On February 4th, 2014, 12:04 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 12:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Fix linking on windows
Automoc only looks at <basename>.h and <basename>_p.h, since this does not
match we have to explicitly include moc_networking(_p).cpp
-------------------------------------------------------------------------------
2) Fix compilation on windows by including qt_windows.h
This file makes sure that NOMINMAX is defined so the build can succeed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles now, didn't before</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/networking_win.cpp <span style="color: grey">(62ebacbe8b3ee421bf8e404d72dba4619c2a7e73)</span></li>
<li>autotests/solidhwtest.cpp <span style="color: grey">(0e3fa05351f27165eb443e90324abacf911a8b0d)</span></li>
<li>src/solid/backends/win/windevicemanager.h <span style="color: grey">(b73ccfcd0588fe39e2a32cde501119ca3877f552)</span></li>
<li>src/solid/backends/win/winstoragedrive.cpp <span style="color: grey">(357699fc1d0f7cca1d7e68e0a2a9f875288e5453)</span></li>
<li>src/solid/backends/win/winstoragevolume.cpp <span style="color: grey">(eae68af57dca253d962d9802d6a9a876cb563b72)</span></li>
<li>src/solid/backends/wmi/wmiquery.h <span style="color: grey">(8f3f0a458ad517153a0a76a812175346e84452fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115343/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>