<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115459/">https://git.reviewboard.kde.org/r/115459/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any particular reason for not using an abstract class? The D macro makes the code a bit surprising to read.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115459/diff/1/?file=241745#file241745line50" style="color: black; font-weight: bold; text-decoration: underline;">src/kwindowsystem_p_x11.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">50</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">setIcons</span><span class="p">(</span><span class="n">WId</span> <span class="n">win</span><span class="p">,</span> <span class="k">const</span> <span class="n">QPixmap</span> <span class="o">&</span><span class="n">icon</span><span class="p">,</span> <span class="k">const</span> <span class="n">QPixmap</span> <span class="o">&</span><span class="n">miniIcon</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nitpick: remove extra space</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115459/diff/1/?file=241745#file241745line106" style="color: black; font-weight: bold; text-decoration: underline;">src/kwindowsystem_p_x11.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">106</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">StrutData</span><span class="p">()</span> <span class="p">{}</span> <span class="c1">// for QValueList to be happy</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QValueList! looks like an old comment :)</pre>
</div>
<br />
<p>- Aurélien Gâteau</p>
<br />
<p>On February 4th, 2014, 9:13 a.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, kdewin and Alexander Richardson.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 4, 2014, 9:13 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Introduce runtime platform support in KWindowSystem
This is a change similar to the one in KWindowInfo, but with variation
to the pattern due to the static container.
There is now a generic implementation of KWindowSystem which is
completely windowing system platform independent. This implementation
delegates all methods into a KWindowSystemPrivate class.
Each windowing system platform implementation needs to provide a
subclass (e.g. KWindowSystemPrivateX11) and provide all the methods
which are delegated. Note that there are no virtual methods defined,
instead the d-pointer gets casted into the proper type. Thus if a
method is not provided it will end in a compile error.
To make use of a platform implementation it needs to be included in
the ctor of KWindowSystemStaticContainer and the PlatformImplementation
enum needs to be extended by a value for the platform. This is used in
the D macro to cast and delegate correctly.
There is a dummy implementation for all not supported windowing system
platforms.
This change also includes some API changes:
* KWindowSystem::windows() returns a copy instead of const-ref
* All methods are provided, there is no longer X11 specific methods
* private methods and enums are removed
NOTE: This change breaks the implementation for Windows and Mac OS!
They are currently excluded from build.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests still succeed for X11, but they are not complete, though the most important aspects are tested.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kwindowsystem_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kwindowsystem_p_x11.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kwindowsystem_x11.cpp <span style="color: grey">(0556ec6bff7b1b5b70018758c984906687890911)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(23133d581944a8373b9b753b300d97054b7d6f18)</span></li>
<li>src/kwindowinfo.cpp <span style="color: grey">(790c4458075ff0ddc22102111e2d96f8c636f0ee)</span></li>
<li>src/kwindowsystem.h <span style="color: grey">(6c2338e28ae8bb9763dfcf14eeb239bdaebda73d)</span></li>
<li>src/kwindowsystem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115459/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>