<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115430/">https://git.reviewboard.kde.org/r/115430/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115430/diff/1/?file=241312#file241312line51" style="color: black; font-weight: bold; text-decoration: underline;">autotests/readtest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">args</span><span class="p">.</span><span class="n">count</span><span class="p">()</span> <span class="o"><</span> <span class="mi">1</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you meant "> 1" here</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115430/diff/1/?file=241337#file241337line57" style="color: black; font-weight: bold; text-decoration: underline;">autotests/writetest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">args</span><span class="p">.</span><span class="n">count</span><span class="p">()</span> <span class="o"><</span> <span class="mi">1</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same here</pre>
</div>
<br />
<p>- Aurélien Gâteau</p>
<br />
<p>On February 2nd, 2014, 4:11 a.m. CET, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2014, 4:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add simple autotests
Two main tests: read the file and compare to a given image (loaded from
png), and write a file out and compare to a previously-written image.
The write test in particular is kind of fragile, but it should help
catch some errors where a code change was not intended to affect the
output of the plugin.
Tests are included for all the writable formats, as well as every
readable format that GIMP can write to (and so I could easily get an
example of).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests build and pass.
Reference images PNG images are correct by inspection (checked with Gwenview on KDE 4).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/write/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgb.rgb <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgb.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgb.xv <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgba.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgba.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgba.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgba.xv <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/writetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(b57287b94cc4c6f108737a3dc8831eecac57cf40)</span></li>
<li>autotests/read/xv/rgb.xv <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xv/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xv/bw.xv <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xv/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-rgba-gimp-2.8.10.xcf <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-rgba-gimp-2.8.10.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-rgb-gimp-2.8.10.xcf <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-rgb-gimp-2.8.10.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-bwa-gimp-2.8.10.xcf <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-bwa-gimp-2.8.10.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-bw-gimp-2.8.10.xcf <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/xcf/simple-bw-gimp-2.8.10.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgba.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgba.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-top-left.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-top-left.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-rle-top-left.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-rle-top-left.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-rle-bottom-left.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-rle-bottom-left.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-bottom-left.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/rgb-gimp-2.8.10-bottom-left.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/bwa.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/bwa.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/bw.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/tga/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb.rgb <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb-gimp-2.8.10-uncompressed.rgb <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb-gimp-2.8.10-uncompressed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb-gimp-2.8.10-rle.rgb <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb-gimp-2.8.10-rle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb-gimp-2.8.10-aggressive-rle.rgb <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/rgb-gimp-2.8.10-aggressive-rle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/bw.rgb <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/rgb/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pcx/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pcx/rgb-gimp-2.8.10.pcx <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pcx/rgb-gimp-2.8.10.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pcx/rgb.pcx <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pcx/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/bw.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/bwa.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/bwa.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/rgb.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/rgba.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pic/rgba.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/psd/rgb-gimp-2.8.10.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/psd/rgb-gimp-2.8.10.psd <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/ras/rgb-gimp-2.8.10-standard.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/ras/rgb-gimp-2.8.10-standard.ras <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgb.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgb.pcx <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgb.jp2 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/rgb.eps <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bwa.xv <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bwa.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bwa.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bwa.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.xv <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.tga <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.rgb <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.pic <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.pcx <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.jp2 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/write/bw.eps <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/readtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/pcx/bw.pcx <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/jp2/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/jp2/rgb.jp2 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/jp2/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/jp2/bw.jp2 <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/eps/rgb.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/eps/rgb.eps <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/eps/rgb-gimp-2.8.10.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/eps/rgb-gimp-2.8.10.eps <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(df7d02f379c5cd0e8040d4286701eb8cdc9f68ee)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/eps/bw.eps <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/read/eps/bw.png <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115430/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>