<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115423/">https://git.reviewboard.kde.org/r/115423/</a>
</td>
</tr>
</table>
<br />
<p>On February 1st, 2014, 5:52 p.m. UTC, <b>Michael Palimaka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note that the listed license, and the actual file licenses are a little bit murky in this (and most other frameworks). Here, we have some files that are LGPL-2 or later, some are LGPL-2.1 or later, and some that just say LGPL without any version or "or later" qualification.</pre>
</blockquote>
<p>On February 1st, 2014, 5:54 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it needs some version information: version 3 is substantially different to version 2. However, 2 and 2.1 are essentially the same license, only one is called the "Library GPL" and one is the "Lesser GPL".</pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree, I am just noting that some files such as eps.h do not provide that information (or have the "proper" header either). I guess we could assume 2(.1) due to the age of the file.</pre>
<br />
<p>- Michael</p>
<br />
<p>On February 1st, 2014, 5:55 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Kevin Ottens and Jonathan Riddell.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2014, 5:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a pattern I would like to apply to other frameworks.
Move license information to its proper locations
The BSD license goes in the relevant CMake file, and
COPYING-CMAKE-SCRIPTS is removed. README.md gets a License section
describing the overall license of the framework, as well as a note about
the CMake scripts.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>COPYING-CMAKE-SCRIPTS <span style="color: grey">(4b417765f3a834ce6b0a216f6b6c0fe2d3f0bed5)</span></li>
<li>README.md <span style="color: grey">(cc698ec3535bad5d652419687fa81dff4ebc0987)</span></li>
<li>cmake/FindOpenEXR.cmake <span style="color: grey">(d69f449960a0ff27c35a532bf4492e20978d5dfe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115423/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>