<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115230/">https://git.reviewboard.kde.org/r/115230/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 77f8148cea518bc580707e66ae49d4452ccd612d by Martin Gräßlin to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 27th, 2014, 8:54 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2014, 8:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add platform check to KSelectionOwner and KSelectionWatcher
These are highly X11 specific classes and don't make any sense on a
platform other than xcb and were potentially crashy by using QX11Info
without verifying that the platform is used.
The implementation will now only create the d-ptr in case that the
code is running on the xcb platform and ensures that no call to xcb
is done unconditionally. All methods perform an early return in case
the d-ptr is null. Non-void methods return a sensible default value
in this case.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unit test is not failing. No test on non-X11, though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kselectionowner.h <span style="color: grey">(512bd5ebc6336c3a07d78dd964599d3f48d8eb33)</span></li>
<li>src/kselectionwatcher.cpp <span style="color: grey">(87e0a9612f2bc6ced3de7c31797411b1eb183d41)</span></li>
<li>src/kselectionwatcher.h <span style="color: grey">(798fe70bfc8175764f3fc3d09de97d971d5e57ad)</span></li>
<li>src/kselectionowner.cpp <span style="color: grey">(3715267e280822ba541196d9c63fd28f58cdc7ee)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115230/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>