<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115137/">https://git.reviewboard.kde.org/r/115137/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, kdewin and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2014, 2:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* changed from active screen to active output
* added a small test application which places an override redirect window in the center of the active output and updates whenever the signal is emitted.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The rational for these changes is based on the discussion in http://article.gmane.org/gmane.comp.kde.devel.plasma/27579/
Plasma needs to know which is the active screen and so far only KWin knows it, so we need to make everybody aware of it.
---
Add convenient wrapper for active screen to KWindowSystem
A method is added to get the identifier of the active screen as a
QString and a signal whenever the active screen changes. This method
is only provided for X11, on Windows and Mac a null QString is returned
as the identifier.
Add an active screen property to NETRootInfo
The active screen is intended to be set by KWin to the active screen
it's using. This can be used by a Client to manually position e.g.
override redirect windows on the active screen. It's intended as a help
for multi-screen setups where a Client can only do guesses on where to
position e.g. a notification window.
It's a KDE specific extension as property _KDE_NET_ACTIVE_SCREEN and
announced in the supported properties.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* wm part of NETWM is unit tested
* KWindowSystem is only compile tested (unit testing is difficult as we need a window manager which supports this property which is at the moment of this writing: none)
* Windows and Mac is not even compile tested, that's why kdewin is included in the review. If you have the time for it, please do a compile test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/activeoutputtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(ce68cc505a69ea9a3cf645e9ae587bd89abe1648)</span></li>
<li>src/netwm_p.h <span style="color: grey">(41792b330f7405034f4d51fb31a4de5dd674b6d0)</span></li>
<li>src/netwm_def.h <span style="color: grey">(8b1ccb8bd731aefb9559c8f2b450337b0312ed4d)</span></li>
<li>src/netwm.cpp <span style="color: grey">(84eb137492e0afaaac80e8d26561fd8f8aff9c27)</span></li>
<li>src/netwm.h <span style="color: grey">(393a29de3153a8b291b9fb249bd3eaeb1ba4e7d5)</span></li>
<li>src/kwindowsystem_x11.cpp <span style="color: grey">(01c78c1debf95d5a176e2153139da19abf383c41)</span></li>
<li>src/kwindowsystem_win.cpp <span style="color: grey">(96148b2d808396a3046204e55fd19d767db017c5)</span></li>
<li>autotests/netrootinfotestwm.cpp <span style="color: grey">(120fbee92d0b22862d8ce746b3b30891ecd9f056)</span></li>
<li>src/kwindowsystem.h <span style="color: grey">(3de0fea179dd468a78a265808fc64704027ec30d)</span></li>
<li>src/kwindowsystem_mac.cpp <span style="color: grey">(8bd2ac763fa26ba49e7733fc3ba93e755383928c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115137/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>