<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115292/">https://git.reviewboard.kde.org/r/115292/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm slightly ambivilent about this, on the basis that my view of kde4support is largely "if it ain't broke, don't fix it", but OTOH it does make sense to do these checks in the language they will be used in. There are a whole bunch of other checks in that file that are still being done in C, though (and I suspect some of the check_function_exists calls should really be check_symbol_exists).</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line68" style="color: black; font-weight: bold; text-decoration: underline;">src/ConfigureChecks.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_symbol_exists</span><span class="p">(</span><span class="s">freeaddrinfo</span> <span class="s2">"sys/types.h;sys/socket.h;netdb.h"</span> <span class="s">HAVE_FREEADDRINFO</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check<span class="hl">_cxx</span>_symbol_exists</span><span class="p">(</span><span class="s">freeaddrinfo</span> <span class="s2">"sys/types.h;sys/socket.h;netdb.h"</span> <span class="s">HAVE_FREEADDRINFO</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I believe this isn't even used any more</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line87" style="color: black; font-weight: bold; text-decoration: underline;">src/ConfigureChecks.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_struct_has_member</span><span class="p">(</span><span class="s2">"struct sockaddr"</span> <span class="s">sa_len</span> <span class="s2">"sys/types.h;sys/socket.h"</span> <span class="s">HAVE_STRUCT_SOCKADDR_SA_LEN</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">87</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_struct_has_member</span><span class="p">(</span><span class="s2">"struct sockaddr"</span> <span class="s">sa_len</span> <span class="s2">"sys/types.h;sys/socket.h"</span> <span class="s">HAVE_STRUCT_SOCKADDR_SA_LEN</span><span class="hl"> </span><span class="s"><span class="hl">LANGUAGE</span></span><span class="hl"> </span><span class="s"><span class="hl">CXX</span></span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_struct_has_member</span><span class="p">(</span><span class="s">dirent</span> <span class="s">d_type</span> <span class="s">dirent.h</span> <span class="s">HAVE_DIRENT_D_TYPE</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">88</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_struct_has_member</span><span class="p">(</span><span class="s">dirent</span> <span class="s">d_type</span> <span class="s">dirent.h</span> <span class="s">HAVE_DIRENT_D_TYPE</span><span class="hl"> </span><span class="s"><span class="hl">LANGUAGE</span></span><span class="hl"> </span><span class="s"><span class="hl">CXX</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this LANGUAGE stuff a cmake 3 feature, because it does not appear to exist in cmake 2.8.12</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line89" style="color: black; font-weight: bold; text-decoration: underline;">src/ConfigureChecks.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_prototype_exists</span><span class="p">(</span><span class="s">res_init</span> <span class="s2">"sys/types.h;netinet/in.h;arpa/nameser.h;resolv.h"</span> <span class="s">HAVE_RES_INIT_PROTO</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">check_prototype_exists</span><span class="p">(</span><span class="s">res_init</span> <span class="s2">"sys/types.h;netinet/in.h;arpa/nameser.h;resolv.h"</span> <span class="s">HAVE_RES_INIT_PROTO</span><span class="hl"> </span><span class="s"><span class="hl">LANGUAGE</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This one doesn't even have an argument to LANGUAGE; but CheckPrototypeExists actually already checks using C++</pre>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On January 24th, 2014, 1:55 p.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 1:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A recent change in ECM revealed an issue with ConfigureChecks.cmake, where the check_symbol_exist calls would use the C compiler (with CFLAGS) and the compilation would happen in C++ (with CXXFLAGS). This change ports all checks to CXX where possible.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Refreshed builds for ECM and KDE4Support, both building OK
2. $ grep HAVE_GETADDRINFO src/config-network.h
#define HAVE_GETADDRINFO 1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ConfigureChecks.cmake <span style="color: grey">(7c8951f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>