<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115382/">https://git.reviewboard.kde.org/r/115382/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 603638aa9524660672c47f6af77e767c1dac4ff8 by Michael Palimaka to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 29th, 2014, 3:33 p.m. UTC, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2014, 3:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcrash
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QtGui is not used anywhere, and QtWidgets are only required for tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds. I didn't find any source references to the two dependencies. qwindowdefs.h from QtWidgets was identified as unused through static analysis tool.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcrash.cpp <span style="color: grey">(b8e13a92c822d0bec47280941e7d5dadca5bfb38)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(69dd376a0f08909d77b70c492fc60a5ab5220317)</span></li>
<li>CMakeLists.txt <span style="color: grey">(0ce523b9a5355813285c508fcff8f4c6b80405ba)</span></li>
<li>KF5CrashConfig.cmake.in <span style="color: grey">(f1e6ecfee32f4c54d467f9a08976472c16fe6823)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(b01a5753adb0a3097b315570231edfbff30f89d7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115382/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>