<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115028/">https://git.reviewboard.kde.org/r/115028/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2014, 2:14 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't we maybe just remove these? Especially considerign they already are deprecated in kdelibs 4.
I don't really like disabling compilation of deprecated symbols, especially in this case we're not winning that much.</pre>
</blockquote>
<p>On January 27th, 2014, 7:33 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The better approach would be to make it inline so that it's not in the cpp file at all:
#ifndef KDE_NO_DEPRECATED
QString fullName() const { return property(KUser::FullName); }
#endif
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we don't want the option of disabling compilation, why are we using the #ifndef construction at all?
What about the other parts of this, like replacing KDE_NO_DEPRECATED with KCOREADDONS_NO_DEPRECATED and supressing deprecation warnings while building with the KCOREADDONS_DEPRECATED= definition?</pre>
<br />
<p>- Alex</p>
<br />
<p>On January 15th, 2014, 1:56 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2014, 1:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is mostly an example of how we could improve the deprecation handling. There are two parts: preventing deprecation warnings when building the library itself (see http://build.kde.org/view/Frameworks/job/kwidgetsaddons_master_qt5/11/warnings17Result/NORMAL/package.-1402078525/ for examples) and allowing the framework to be built with no deprecated code.
We possibly want to export the fact that the framework was built without deprecated code via the CMake config file, so that downstream stuff (like kde4support) can check for it and complain if necessary.
Allow the building of deprecated code to be disabled
This adds a CMake option to enable or disable the building of deprected
code. It just changes the kcoreaddons_export.h file.
Part of this change is to use KCOREADDONS_NO_DEPRECATED instead of
KDE_NO_DEPRECATED.
Disable deprecation macro when building the library itself
This prevents spurious compiler warnings (particularly when slots are
deprecated).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/CMakeLists.txt <span style="color: grey">(8cc71f34e671962f2d7268b3db0d50e6750c26a2)</span></li>
<li>src/lib/util/kuser.h <span style="color: grey">(2b6e6ed92bc1465945f36f2fde821f36fa51585f)</span></li>
<li>src/lib/util/kuser_unix.cpp <span style="color: grey">(8a3a39d379ca863b4906bb01228c5e01a5b955b0)</span></li>
<li>src/lib/util/kuser_win.cpp <span style="color: grey">(6a6cbb1751bd569d8684f8e11add1ef304c0a94d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115028/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>