<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115120/">https://git.reviewboard.kde.org/r/115120/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Kevin Ottens</p>


<br />
<p>On January 19th, 2014, 12:23 p.m. UTC, Alex Merry wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>


<p style="color: grey;"><i>Updated Jan. 19, 2014, 12:23 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clean up the CMake files (and a couple of other bits)

src/imageformats/CMakeLists.txt is now much clearer and more consistent.

Also, removed an unnecessary/unimplemented method from exr.cpp.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, installs.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(c39d6f322d335fa5d19e934d0f7c5c602ba1a502)</span></li>

 <li>cmake/FindOpenEXR.cmake <span style="color: grey">(b4ae656722a78e8f3494415e4583709e9b29065e)</span></li>

 <li>src/imageformats/CMakeLists.txt <span style="color: grey">(053054a54ef53b7695b244748c3e5c0f252cc8c3)</span></li>

 <li>src/imageformats/config-kimgio.h.cmake <span style="color: grey">()</span></li>

 <li>src/imageformats/exr.h <span style="color: grey">(3ae9e16e3d6e74240e14ce8994a1d9126c4bdd36)</span></li>

 <li>src/imageformats/exr.cpp <span style="color: grey">(f8c70b7547781614b05936f893a526d12b4a41b1)</span></li>

 <li>src/imageformats/jp2.cpp <span style="color: grey">(5be5063d034b048aa47c5491796a89bc4519d3e4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115120/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>