<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115148/">https://git.reviewboard.kde.org/r/115148/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2014, 7:36 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not... makes me want to ask the same for the other HAVE_FOO we have in the other frameworks. You might have opened the pandora box. :-)</pre>
</blockquote>
<p>On January 27th, 2014, 7:49 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes the same reasoning applies to all frameworks. Though one could also say that using a HAVE_FOO in a public header is clearly wrong and the API needs fixing ;-) (That's certainly the case in KWindowSystem)
This change could break downstream usages as we often got the HAVE_X11 through kwindowsystem. So if we have something like:
#include <kwindowsystem.h>
#if HAVE_X11
KWindowsystem::foo();
#endif
it would break. It's obviously wrong, but some usages of Q_WS_X11 got fast ported to HAVE_X11 and it continued to compile thanks to the kwindowsystem include. (In such a pattern also having the ifdef at all is wrong, but also this is quite common that KWindowsystem is incorrectly wrapped around ifdef)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think other frameworks install their config files, though; this is only an issue when these things appear in public headers.</pre>
<br />
<p>- Alex</p>
<br />
<p>On January 26th, 2014, 5:36 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 26, 2014, 5:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwindowsystem
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines
config-kwindowsystem.h is installed and included by public headers, so
it should not define things as generic as "HAVE_X11", which are likely
to also be defined by users of the framework.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clean configure-build-test-install on a system with X11. KWindowSystem already failed to build on a non-windows, non-mac system when X11 is not found (one of the tests fails to link if you comment out the find_package(X11) calls, as KWindowSystem::activeWindow() is never defined).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/netwm.cpp <span style="color: grey">(266afccaf111e6707493b18dad1d9c03dde1d912)</span></li>
<li>src/netwm.h <span style="color: grey">(aee6cea5e3b65cf6252b50515e4920cb9c96f240)</span></li>
<li>src/kxerrorhandler.cpp <span style="color: grey">(612e62a345ec9c8503bab9fb12afa08426974828)</span></li>
<li>src/kxerrorhandler_p.h <span style="color: grey">(ad670fec6ff35e1c9df81b91517c02e6e0893ad1)</span></li>
<li>src/kxmessages.h <span style="color: grey">(5d57e06d702afb5ceaed05de97ca40116b7f3aa3)</span></li>
<li>src/kxmessages.cpp <span style="color: grey">(b409ef2114c18190188ba5503d2f357bd9336e76)</span></li>
<li>src/kxutils.cpp <span style="color: grey">(e47ba68c08a14597e49fd33901b0a7c079924112)</span></li>
<li>src/kxutils_p.h <span style="color: grey">(1e229801aac929bc596685dbfa5260d55d0f5298)</span></li>
<li>src/kusertimestamp.cpp <span style="color: grey">(de8ca61e7e9dd0ae9492ccf61883560d80501e2b)</span></li>
<li>src/kstartupinfo.cpp <span style="color: grey">(5dbf47cb666fbed17c943491efe93e17f27d581e)</span></li>
<li>src/kkeyserver.h <span style="color: grey">(8869fe7331e98846183ab37814b1d95e75ab9647)</span></li>
<li>src/config-kwindowsystem.h.cmake <span style="color: grey">(58949d87f4254531ba57de86b6303cba05053222)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b453af11a46615ecd94911f0d2f86922087bde0e)</span></li>
<li>CMakeLists.txt <span style="color: grey">(2479237e574e86c9094b557dfa146c85b7b19b65)</span></li>
<li>src/kwindoweffects.cpp <span style="color: grey">(91ef52f149a781df9308bb1587629dbaaf571b8e)</span></li>
<li>src/kwindoweffects_p.h <span style="color: grey">(266b5f3e7f24bdca6ce467138ee067335225da78)</span></li>
<li>src/kwindowsystem.h <span style="color: grey">(5bcfd062dcca42d282b70d0683d4ee1da88cc814)</span></li>
<li>src/kwindowsystem_x11.cpp <span style="color: grey">(8634240cabc708a608277b34f21c41cee295e48a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115148/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>