<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115285/">https://git.reviewboard.kde.org/r/115285/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I guess, you will delete the oxygen implementation when this is done, right ?
(for the record, I had some implementation detail comments about it. Guess I might have missed the review, or read not carefully enough)</pre>
<br />
<p>- Hugo Pereira Da Costa</p>
<br />
<p>On January 24th, 2014, 9:36 a.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Hugo Pereira Da Costa.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 9:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows
This feature is upstreamed from the Oxygen style. It is a general
feature for integration with our window manager and thus should be in
the generic style implementation and not just in Oxygen.
So far the implementation only supports X11 and installs an X property
on all toplevel windows. On other platforms it is currently a no-op.
This introduces an optional dependency on XCB and QtX11Extras. If they
are not found the feature is obviously not compiled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the kcolorschemedemo in kconfigwidgets/tests and an adjusted Oxygen without the feature.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kstyle/CMakeLists.txt <span style="color: grey">(41c92c266a92e4e3534114c982ed98cf529456d5)</span></li>
<li>src/kstyle/kstyle.cpp <span style="color: grey">(f79675b85a58d0f132bc3d336996d51a2661e567)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115285/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>