<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115289/">https://git.reviewboard.kde.org/r/115289/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Chusslove Illich.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2014, 5:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ki18n
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">MSVC fix: Check for libintl.h and libintl.lib
On MSVC we have libintl as a separate library and must therefore explicitly
link to it. This is not required on linux since gettext is part of glibc.
On Windows libintl.h is not always found in the default include path and
has to be searched for.
Fix linking on MSVC by using KTRANSCRIPT_EXPORT</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles on Windows, no change to Linux</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ktranscript.cpp <span style="color: grey">(e0570f1cccabb8e3a59ff952eac2817081ec4e9e)</span></li>
<li>src/kcatalog.cpp <span style="color: grey">(d337a50fb973e810e549671b60b2227db78d0628)</span></li>
<li>src/gettext.h <span style="color: grey">(3d3c2733576b5d2b977c3360519636662caf18c5)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(bfb7d793a8cea883378555368eeec7582e8f88b1)</span></li>
<li>cmake/FindLibIntl.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(165f8c84156ebdb5034424752cc5f80a5d70319c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115289/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>