<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115236/">https://git.reviewboard.kde.org/r/115236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 23rd, 2014, 10:35 a.m. CET, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this been compile-tested on Linux?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, I check that all these windows changes work on linux, too. Don't want to break my primarily used platform ;)</pre>
<br />
<p>- Alexander</p>
<br />
<p>On January 22nd, 2014, 10:12 p.m. CET, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 10:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">3 Commits to get closer to compiling on windows:
1. Include qplatformdefs.h where possible
unistd.h and others are not available on e.g. Windows,
qplatformdefs.h includes the equivalent for each platform
2. add include(CheckLibraryExists) to CMakeLists.txt
On Linux this is apparently pulled in by some other file
whereas it is missing on Windows
3. Make KIO::MetaData completely inline to prevent linker errors on MSVC</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/ftp/ftp.h <span style="color: grey">(ad94979829a5d0e71ec57177b51f67e115c5445e)</span></li>
<li>src/ioslaves/ftp/ftp.cpp <span style="color: grey">(9ea642587bd754f0b4295fcb7d4db1b427f4326e)</span></li>
<li>src/ioslaves/help/kio_help.h <span style="color: grey">(0eab4ce1b393b48e552ca94d877f4c069450cee0)</span></li>
<li>src/ioslaves/http/http.cpp <span style="color: grey">(4f97b335c0e206f0a2ff8cfd515d0fae79614ad2)</span></li>
<li>src/ioslaves/http/http_cache_cleaner.cpp <span style="color: grey">(ffa8ab9580acf554b27027617cdac06b3f7755bf)</span></li>
<li>src/widgets/kdirmodel.cpp <span style="color: grey">(ce6e4c9aaddada5715b5aeef36ad163c77d3c635)</span></li>
<li>src/widgets/kpropertiesdialog.cpp <span style="color: grey">(8ddd37f0326e37109ce239a46bfa67d2f4c35411)</span></li>
<li>src/widgets/krun.cpp <span style="color: grey">(92dcfd8da04b9f3d80b632a37758017c088093ab)</span></li>
<li>src/widgets/kurlcompletion.cpp <span style="color: grey">(ed77fd3213db0524b5a934c94eb7645d98bd27c7)</span></li>
<li>tests/kioslavetest.cpp <span style="color: grey">(dc56240dc166dfa93ec099db5cdd262cc06249d4)</span></li>
<li>tests/kruntest.cpp <span style="color: grey">(68720ddf788e6b44468baf18dd04937094741274)</span></li>
<li>CMakeLists.txt <span style="color: grey">(9894ad5e1696fe31d8a3f065d29747cde0474d2c)</span></li>
<li>autotests/fileundomanagertest.cpp <span style="color: grey">(4ddee49eed254be6379a1302af2dd17aae28c15c)</span></li>
<li>autotests/kurlcompletiontest.cpp <span style="color: grey">(10048e2e15059596e446b03cedb0b302bf038cd5)</span></li>
<li>src/core/chmodjob.cpp <span style="color: grey">(b60cb9bf3d3b1a71a795ee5db7c72253dbdf0ad2)</span></li>
<li>src/core/kacl.h <span style="color: grey">(3c9c88d0408c855d02eaacb34d14f45c55343eb2)</span></li>
<li>src/core/kacl.cpp <span style="color: grey">(201b30a02ef93a137b9a8507cabaece6926d8739)</span></li>
<li>src/core/kfileitem.h <span style="color: grey">(553dbf8ccf96983803d0224cf8dc9d72f0107b6a)</span></li>
<li>src/core/kfileitem.cpp <span style="color: grey">(fdc0fc0279713887dc18ce1da8d3b00d422f6a9b)</span></li>
<li>src/core/kprotocolmanager.cpp <span style="color: grey">(a8746a4f9a78e6a01eaed6a70e99146ff40129d2)</span></li>
<li>src/core/krecentdocument.cpp <span style="color: grey">(ad0a97e7c1af85a94bb7483124b5035f0fca38a6)</span></li>
<li>src/core/metadata.h <span style="color: grey">(cd62e3b009c21485537ddd5449a6c347748c3caf)</span></li>
<li>src/core/metadata.cpp <span style="color: grey">(ad05032dff58314a305256993fcc7fe7b94751bc)</span></li>
<li>src/core/slave.h <span style="color: grey">(43b5cd8e8aa11da55d6f8a8d9fdf4eb3d0780d11)</span></li>
<li>src/core/slave.cpp <span style="color: grey">(ef9b3c7a57b4f4384343c4d4296ec88add857eb6)</span></li>
<li>src/core/slavebase.cpp <span style="color: grey">(a7ac4d5a6a87c256da9a3947b7223649927eba39)</span></li>
<li>src/core/slaveinterface.h <span style="color: grey">(d75eb6b02374375a73e1aaa57d5c2979a3bc365f)</span></li>
<li>src/core/slaveinterface.cpp <span style="color: grey">(faa4bd7dc1b5a733f0060f60626e8a0313bfea8a)</span></li>
<li>src/core/slaveinterface_p.h <span style="color: grey">(0ed4980a06f8aa8b3fc8c0717e4a88991483e98a)</span></li>
<li>src/filewidgets/kfileplaceeditdialog.cpp <span style="color: grey">(a7c433c8baecca8082f8d80077deab68e4b0cec2)</span></li>
<li>src/filewidgets/knewfilemenu.cpp <span style="color: grey">(dfc086b6e98b965739c062d7291bbd9139633beb)</span></li>
<li>src/ioslaves/file/file.h <span style="color: grey">(453298159791a78d877c4d81d2be73db073db3f2)</span></li>
<li>src/ioslaves/file/file.cpp <span style="color: grey">(e3ede0daa8054fc33d12acb9966a707f9484cd98)</span></li>
<li>src/ioslaves/file/file_win.cpp <span style="color: grey">(53e0f8f133bd5c4cbbd07afa945854efffc7297c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115236/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>