<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115185/">https://git.reviewboard.kde.org/r/115185/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 21st, 2014, 6:16 p.m. CET, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- files should have licenses and encoding marks
- "kf5dot" is not very descriptive as a name. I would call the module "dependencies" or "depdiags" or something like that, and the scripts something similar but with a k or kf5 prefix
- it would be nice if kgenframeworksapidox could do all the magic itself, when suitable option(s) are passed (although that can be something to implement later)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> - files should have licenses and encoding marks
Will fix.
> - "kf5dot" is not very descriptive as a name. I would call the module "dependencies" or "depdiags" or something like that, and the scripts something similar but with a k or kf5 prefix
I am not happy with the name either, but I think this can be fixed in a different commit.
> - it would be nice if kgenframeworksapidox could do all the magic itself, when suitable option(s) are passed (although that can be something to implement later)
Agreed.</pre>
<br />
<p>- Aurélien</p>
<br />
<p>On January 21st, 2014, 5:58 p.m. CET, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Alex Merry.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2014, 5:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kapidox
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This big patch includes all of the kf5dot repository inside kapidox. Python code is in src/kapidox/kf5dot, scripts are in src/.
I replayed all the commits from the kf5dot repository within the kapidox repository using `git am` to avoid loosing history. As such, I plan to do the merge using --no-ff.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Generated all diagrams. Works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kapidox/kf5dot/frameworkdb.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kf5dot-generate <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kf5dot-generate-all <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kf5dot-prepare <span style="color: grey">(PRE-CREATION)</span></li>
<li>README.md <span style="color: grey">(660e9c3)</span></li>
<li>src/kapidox/kf5dot/framework.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>setup.py <span style="color: grey">(025afdb)</span></li>
<li>src/kapidox/kf5dot/.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kapidox/kf5dot/block.py <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115185/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>