<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115213/">https://git.reviewboard.kde.org/r/115213/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 22nd, 2014, 11:32 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, but frameworks are not only for frameworks. They're all ported because I ported them.
OTOH, there will be non-ported applications, that's why we provide this warning.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You ported KDE4_CREATE_HANDBOOK, which is widely used in kdelibs4-based code:
http://lxr.kde.org/search?filestring=&string=KDE4_CREATE_HANDBOOK
On the other side, KDE4_CREATE_HTML_HANDBOOK has never been used in a stable version (not in 4 at least), please check the dates:
http://mail.kde.org/pipermail/kde-buildsystem/2007-January/003643.html
http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=61dd00ab3211bb7b76a94344ed8d577a6d194cf1
http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=82f7b6ba0f8be7d314ac780b9a873e98b6be39b2
</pre>
<br />
<p>- Luigi</p>
<br />
<p>On January 22nd, 2014, 7:01 a.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Luigi Toscano.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 7:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed in Review Request 115077</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Searched all CMakeLists.txt files of frameworks for that macro, found nothing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5DocToolsMacros.cmake <span style="color: grey">(191a2c5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>