<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115212/">https://git.reviewboard.kde.org/r/115212/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 7:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Dropped the foreach change, this is fixed by https://git.reviewboard.kde.org/r/115234/</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">3 separate commits:
1. Fix windows build with QT_NO_CAST_FROM_ASCII
2. m_collator already returs bool, remove check for < 0
3. Don't use uname() and getpwuid() directly
Added new functions that also do the right thing on Windows</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">now it compiles on windows and Linux is still fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kbugreport.cpp <span style="color: grey">(56f088106becbccca5e9731abc04118a19e36ba9)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(4516a9ee3da774788c76f30f15181fa0049a9d86)</span></li>
<li>src/ksendbugmail/CMakeLists.txt <span style="color: grey">(12b4926ecddeb023315f6074ab57cfe6cdee65ff)</span></li>
<li>src/ksendbugmail/main.cpp <span style="color: grey">(8f85f315f0746bb774175114b1e284e899957fd3)</span></li>
<li>src/ksendbugmail/smtp.cpp <span style="color: grey">(90b6b98467b0c220cfef18bc35cf3c07df9a8cf3)</span></li>
<li>src/kshortcutseditoritem.cpp <span style="color: grey">(086f833fc505f69a3b0dbe6fceffdb94ecd60330)</span></li>
<li>src/systeminformation_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kkeysequencewidget.cpp <span style="color: grey">(cc9016b776c16984b83a36a2742526ede624bf5e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115212/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>