<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115209/">https://git.reviewboard.kde.org/r/115209/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Would it be possible to unify the two "add_custom_command" by redefining only docbookl10nhelper_EXE into the WIN32 block?
Could you please add the kdewin group as reviewers so that they can check if it works with gcc too?
</pre>
<br />
<p>- Luigi Toscano</p>
<br />
<p>On January 22nd, 2014, 1:26 a.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 1:26 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two separate commits:
-----------------------------------
Print a message when a file is not found
This way meinproc no longer fails silently
----------------------------------
Allow compiling on Windows with MSVC</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(752604190a4b527d757d4b819dc6d85085a96e4b)</span></li>
<li>src/meinproc.cpp <span style="color: grey">(f34084581205ad4f63a84823cd1a582b2f37ed69)</span></li>
<li>src/meinproc_common.cpp <span style="color: grey">(16234f70e45a703859fce42dcdb2ac1c2fdadade)</span></li>
<li>src/xslt.cpp <span style="color: grey">(79578ed8fb6cc3faccf63b8d86e29db9948b33e7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115209/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>