<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115157/">https://git.reviewboard.kde.org/r/115157/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for pointing out issues in KWindowSystem. I do hope that Windows and Mac developers will start fixing that</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115157/diff/1/?file=234862#file234862line466" style="color: black; font-weight: bold; text-decoration: underline;">src/kpassivepopup.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QPoint KPassivePopup::defaultLocation() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">462</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">widget</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">455</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QWidget</span> <span class="o">*</span><span class="n">widget</span> <span class="o">=</span> <span class="n">QWidget</span><span class="o">::</span><span class="n">find</span><span class="p">(</span><span class="n">d</span><span class="o">-></span><span class="n">window</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">463</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">target</span></span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n">widget</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">geometry</span></span><span class="p"><span class="hl">();</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">456</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">if</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n">widget</span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">small suggestion:
if (QWidget *widget = QWidget::find(d->window)) {
...
}</pre>
</div>
<br />
<p>- Martin Gräßlin</p>
<br />
<p>On January 20th, 2014, 6:58 p.m. CET, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks, Martin Gräßlin and Michael Palimaka.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2014, 6:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is an alternative approach to https://git.reviewboard.kde.org/r/115147/ where we avoid doing the cross platform support ourselves, and instead depend on KWindowSystem.
Downsides: it looks like the implementations for KWindowInfo::geometry() and KWindowInfo::frameGeometry are the wrong way round on windows, and they are not implemented at all on Mac. However, the code we had here was never tested either, so...
Make better use of KWindowSystem in KPassivePopup
This avoids having code that is compiled on non-X11 platforms but not on
X11 (the old non-X11 code did not compile).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles and tests work when X11 is found. Compiles and tests do as well as expected (ie: popups are placed next to the window instead of the taskbar entry) when X11 is not found (specifically by commenting out find_package(X11)).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(022cbcb7a12aa5ad9843019ffd73f1b3e117fb9b)</span></li>
<li>src/kpassivepopup.cpp <span style="color: grey">(b41cb8dc8b3372346bd12c0413bf6bfa9a6fd00d)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(c7481362008e3cae10d0afcfbcaea5fe953ce62d)</span></li>
<li>tests/kpassivepopuptest.cpp <span style="color: grey">(f457aed7e57904bcc00462a947bc5eaae7208792)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115157/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>