<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115164/">https://git.reviewboard.kde.org/r/115164/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems sensible to me, but I would add Valentin Rusu to the review.</pre>
<br />
<p>- Alex Merry</p>
<br />
<p>On January 21st, 2014, 10:38 a.m. UTC, Michael Palimaka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Michael Palimaka.</div>
<p style="color: grey;"><i>Updated Jan. 21, 2014, 10:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together.
(I don't know why git didn't recognise certain files as just being moved in the diff)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds, affected tests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/kcookiejar/tests/cookie_rfc.test <span style="color: grey">()</span></li>
<li>src/ioslaves/http/kcookiejar/tests/cookie_saving.test <span style="color: grey">()</span></li>
<li>src/ioslaves/http/kcookiejar/tests/cookie_session.test <span style="color: grey">()</span></li>
<li>src/ioslaves/http/kcookiejar/tests/cookie_settings.test <span style="color: grey">()</span></li>
<li>src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpauthenticationtest.h <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpauthenticationtest.cpp <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpfiltertest.cpp <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpheaderdispositiontest.h <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpheaderdispositiontest.cpp <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpheadertokenizetest.h <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpheadertokenizetest.cpp <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpobjecttest.h <span style="color: grey">()</span></li>
<li>src/ioslaves/http/tests/httpobjecttest.cpp <span style="color: grey">()</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(5655d45efcfd9455e1745a2ec93e2da30a9b83b2)</span></li>
<li>autotests/http/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/httpfiltertest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpauthenticationtest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpauthenticationtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpheaderdispositiontest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpheaderdispositiontest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpheadertokenizetest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpheadertokenizetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpobjecttest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/http/tests/httpobjecttest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcookiejar/kcookiejartest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcookiejar/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcookiejar/tests/cookie.test <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcookiejar/tests/cookie_rfc.test <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcookiejar/tests/cookie_saving.test <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcookiejar/tests/cookie_session.test <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/kcookiejar/tests/cookie_settings.test <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/ioslaves/http/CMakeLists.txt <span style="color: grey">(39fccccd42f62bd583f92f655739a97a02b09c61)</span></li>
<li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(54b1fe0b818f63cd76ac79d5233a3c00da866950)</span></li>
<li>src/ioslaves/http/kcookiejar/tests/CMakeLists.txt <span style="color: grey">()</span></li>
<li>src/ioslaves/http/kcookiejar/tests/cookie.test <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115164/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>