<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115120/">https://git.reviewboard.kde.org/r/115120/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On January 19th, 2014, 8:07 p.m. UTC, <b>David Faure</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/115120/diff/1/?file=234669#file234669line53" style="color: black; font-weight: bold; text-decoration: underline;">src/imageformats/CMakeLists.txt</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span class="nb">install</span><span class="p">(</span><span class="s">FILES</span> <span class="s">eps.desktop</span> <span class="s">DESTINATION</span>  <span class="o">${</span><span class="nv">SERVICES_INSTALL_DIR</span><span class="o">}</span><span class="s">/qimageioplugins/</span><span class="p">)</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="nb">install</span><span class="p">(</span><span class="s">FILES</span> <span class="s">eps.desktop</span> <span class="s">DESTINATION</span> <span class="o">${</span><span class="nv">SERVICES_INSTALL_DIR</span><span class="o">}</span><span class="s">/qimageioplugins/</span><span class="p">)</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remind me, who uses these desktop files?

Only the kde4support code, right?</pre>
 </blockquote>



 <p>On January 20th, 2014, 10:29 a.m. UTC, <b>Alex Merry</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep.  I must get round to submitting that patch to Qt that should allow us to ditch them...</pre>
 </blockquote>







</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, and there's also a comment at the top of the CMakeLists.txt file to that effect.</pre>
<br />




<p>- Alex</p>


<br />
<p>On January 19th, 2014, 12:23 p.m. UTC, Alex Merry wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>


<p style="color: grey;"><i>Updated Jan. 19, 2014, 12:23 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kimageformats
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clean up the CMake files (and a couple of other bits)

src/imageformats/CMakeLists.txt is now much clearer and more consistent.

Also, removed an unnecessary/unimplemented method from exr.cpp.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, installs.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(c39d6f322d335fa5d19e934d0f7c5c602ba1a502)</span></li>

 <li>cmake/FindOpenEXR.cmake <span style="color: grey">(b4ae656722a78e8f3494415e4583709e9b29065e)</span></li>

 <li>src/imageformats/CMakeLists.txt <span style="color: grey">(053054a54ef53b7695b244748c3e5c0f252cc8c3)</span></li>

 <li>src/imageformats/config-kimgio.h.cmake <span style="color: grey">()</span></li>

 <li>src/imageformats/exr.h <span style="color: grey">(3ae9e16e3d6e74240e14ce8994a1d9126c4bdd36)</span></li>

 <li>src/imageformats/exr.cpp <span style="color: grey">(f8c70b7547781614b05936f893a526d12b4a41b1)</span></li>

 <li>src/imageformats/jp2.cpp <span style="color: grey">(5be5063d034b048aa47c5491796a89bc4519d3e4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115120/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>