<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115098/">https://git.reviewboard.kde.org/r/115098/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 18th, 2014, 8:58 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why does this remove some forwarding headers?</pre>
</blockquote>
<p>On January 18th, 2014, 3:26 p.m. UTC, <b>Friedrich W. H. Kossebau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because they are installed from the KParts module itself already, with the same forwarding include path. So no need to duplicate them in KDE4Support, or?
(Only difference is those from KParts have '"' around the path, not '<' and '>'. This is a small error in ecm_generate_headers still, it needs to add ../ in front of the path in case of a prefixed path. Other option would be '<' as well '>', but a relative link seems safer to me)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But this is the case for most of the forwarding headers installed by kde4support. They "duplicate" the ones installed by the frameworks.
One reason is that the ones from kde4support go into include/KDE, so they make old-style <KDE/KParts/Part> work, and the other reason is historical (we had this before we had ecm_generate_header).</pre>
<br />
<p>- David</p>
<br />
<p>On January 18th, 2014, 3:48 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2014, 3:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Counterpart to: https://git.reviewboard.kde.org/r/115097/
Main discussion over there, please.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/includes/KParts/OpenUrlEvent <span style="color: grey">(c3e9e59)</span></li>
<li>src/includes/KParts/Part <span style="color: grey">(bcb6c5e)</span></li>
<li>src/includes/KParts/PartActivateEvent <span style="color: grey">(dabdd2f)</span></li>
<li>src/includes/KParts/PartBase <span style="color: grey">(bcb6c5e)</span></li>
<li>src/includes/KParts/PartManager <span style="color: grey">(2dcfeb3)</span></li>
<li>src/includes/KParts/PartSelectEvent <span style="color: grey">(dabdd2f)</span></li>
<li>src/includes/KParts/Plugin <span style="color: grey">(f73168d)</span></li>
<li>src/includes/KParts/ReadOnlyPart <span style="color: grey">(bcb6c5e)</span></li>
<li>src/includes/KParts/ReadWritePart <span style="color: grey">(bcb6c5e)</span></li>
<li>src/includes/KParts/StatusBarExtension <span style="color: grey">(8c8a481)</span></li>
<li>src/includes/KParts/TextExtension <span style="color: grey">(cb73ab5)</span></li>
<li>src/includes/KParts/WindowArgs <span style="color: grey">(c3e9e59)</span></li>
<li>src/kparts/listingextension.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(23b0d6d)</span></li>
<li>src/includes/CMakeLists.txt <span style="color: grey">(2b2130f)</span></li>
<li>src/includes/KParts/BrowserExtension <span style="color: grey">(c3e9e59)</span></li>
<li>src/includes/KParts/BrowserHostExtension <span style="color: grey">(c3e9e59)</span></li>
<li>src/includes/KParts/BrowserInterface <span style="color: grey">(640f47b)</span></li>
<li>src/includes/KParts/BrowserRun <span style="color: grey">(b63479b)</span></li>
<li>src/includes/KParts/Event <span style="color: grey">(dabdd2f)</span></li>
<li>src/includes/KParts/FileInfoExtension <span style="color: grey">(13c7c41)</span></li>
<li>src/includes/KParts/GUIActivateEvent <span style="color: grey">(dabdd2f)</span></li>
<li>src/includes/KParts/HistoryProvider <span style="color: grey">(b8c3fc9)</span></li>
<li>src/includes/KParts/HtmlExtension <span style="color: grey">(aae280e)</span></li>
<li>src/includes/KParts/ListingExtension <span style="color: grey">(38598f9)</span></li>
<li>src/includes/KParts/LiveConnectExtension <span style="color: grey">(c3e9e59)</span></li>
<li>src/includes/KParts/MainWindow <span style="color: grey">(452e115)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115098/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>