<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115024/">https://git.reviewboard.kde.org/r/115024/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d4ecd4c9689724476acf8f6bbc82938a2d387aae by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 15th, 2014, 12:21 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Andreas Hartmetz.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2014, 12:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove check for X11
The only thing that was using it was a preprocessor branch in
kkeysequencewidget.cpp, which only had branches for Mac and X11. It
appears to be intended to control the order of modifiers in a key
sequence description, but there is no explanation anywhere in the logs
for the fact that it checks for X11.
(Added Andreas as the original author of this code back in the transition to KDE 4).
Update: actually, it looks like this originally used KKeyServer to get the modifier descriptions, which was only implemented for X11 and Mac. So that explains that...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Configure, build, run tests, install.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(11a5af110a101a18e4b5a36f1d7e91a34c1b09c5)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(29e7dfe4aa89c03778bf4137840727fb54c1332b)</span></li>
<li>src/config-xmlgui.h.cmake <span style="color: grey">(bde7885db30843a0cb241d1ee0ac9e22c762d7b3)</span></li>
<li>src/kkeysequencewidget.cpp <span style="color: grey">(65ff05eec6b99cdcf7db5505475f11918b76a767)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115024/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>