<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114888/">https://git.reviewboard.kde.org/r/114888/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114888/diff/1/?file=233311#file233311line56" style="color: black; font-weight: bold; text-decoration: underline;">modules/ECMGenerateHeaders.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">if</span> <span class="p">(</span><span class="s">NOT</span> <span class="o">${</span><span class="nv">EGH_RELATIVE</span><span class="o">}</span> <span class="s">MATCHES</span> <span class="s2">"^.*/$"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since CMake has somewhat unexpected behaviour when using MATCHES with an empty string (I would expect (NOT "" MATCHES "^.*/$") to be true), it might be worth putting a comment in.</pre>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On January 8th, 2014, 12:22 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Extra Cmake Modules and KDE Frameworks.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2014, 12:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When the RELATIVE parameter in ECMGenerateHeaders is empty or not set, the _actualheader variable would be defined to "/cmake/current/source/dir//lowercaseclassname.h".
The double slash breaks RPM's debug symbols extraction, because it canonicalizes the path, so it's shortened by one "/". The shortening is done to avoid double-slash in the beginning of the path, which is non-POSIX. However from my understanding it's not possible to truncate the size of directory table by 1 byte, so the debugedit utility aborts and the entire rpmbuild fails. See a relevant bug report with further information: https://bugzilla.redhat.com/show_bug.cgi?id=304121 (comment #2)
This patch simply makes sure that EGH_RELATIVE is either empty, or non-empty and terminated with slash.
With this patch we are able to build solid and kdnssd frameworks with RPM build tools.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Successfully built solid and kdnssd frameworks with rpmbuild, other frameworks still build too.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMGenerateHeaders.cmake <span style="color: grey">(f72b1c0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114888/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>