<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 01/04/2014 11:21 PM, Dominik Haumann
wrote:<br>
</div>
<blockquote cite="mid:6880199.lxvCCEqPCt@eriador" type="cite">
<pre wrap="">On Saturday 04 January 2014 23:11:14 David Faure wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Saturday 04 January 2014 23:02:35 Dominik Haumann wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Saturday 04 January 2014 20:56:30 Hugo Pereira Da Costa wrote:
</pre>
<blockquote type="cite">
<pre wrap="">ok. So this should go to kstyle (nothing oxygen explicit in there).
In fact, kstyle returns:
KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI Settings");
return g.readEntry("GraphicEffectsLevel", 0);
mmm. No clue which KCM sets this :)
(but that answers Dominik's original question I guess)
</pre>
</blockquote>
<pre wrap="">
Yes, that answers my question. In particular, using the code
widget->style()->styleHint(QStyle::SH_Widget_Animate, 0, widget)
is correct *if* we use a KStyle based style.
</pre>
</blockquote>
<pre wrap="">
No, it's correct in all cases :)
With the other Qt styles you get "true", which is the correct default value.
</pre>
</blockquote>
<pre wrap="">
Ok, I missed this one, thanks for the clarification!
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">What I personally would like more is to always be able to read this.
I of course can use a KSharedConfig::openConfig() and then read the config
value myself. However, would it be of interest to have a static accessor
for this? Downside is that there are quite a lot of kdeglobals dependent
entries...
Is the preferred way to read this value manually then in KatePart?
Would that also be the preferred way in KMessageWidget?
</pre>
</blockquote>
<pre wrap="">
I don't really see what the issue is. Do you care that much for Windows
users to be able to turn animations off?
</pre>
</blockquote>
<pre wrap="">
Nevermind, was a misunderstanding then.
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Another issue we have in Kate code: kdeglobals right now do not have this
effects enabled by default. A unit test from kde4 times now fails in kf5,
because the timings are different, because the effects are off.
Are there plans to have a kdeglobals that has enabled effects?
</pre>
</blockquote>
<pre wrap="">
As I said, it's a bug in the readEntry() call above. The default is supposed
to be 1, so you don't need a special kdeglobals.
</pre>
</blockquote>
<pre wrap="">
Ok, so who is going to fix it? ;) Hugo?</pre>
</blockquote>
Question<br>
should the default simply be "1"<br>
or should kstyle re-introduce the same enumeration that was in
KGlobalSettings ? <br>
<br>
<meta name="qrichtext" content="1">
<p style="-qt-paragraph-type:empty; margin-top:0px;
margin-bottom:0px; margin-left:0px; margin-right:0px;
-qt-block-indent:0; text-indent:0px;"><br>
</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"> enum GraphicEffect {</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"> NoEffects = 0x0000, ///< GUI with no
effects at all.</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"> GradientEffects = 0x0001, ///< GUI with
only gradients enabled.</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"> SimpleAnimationEffects = 0x0002, ///< GUI
with simple animations enabled.</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"> ComplexAnimationEffects = 0x0006 ///< GUI
with complex animations enabled.</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"> ///< Note that ComplexAnimationsEffects
implies SimpleAnimationEffects.</p>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px;
margin-right:0px; -qt-block-indent:0; text-indent:0px;
-qt-user-state:0;"> };</p>
<p style="-qt-paragraph-type:empty; margin-top:0px;
margin-bottom:0px; margin-left:0px; margin-right:0px;
-qt-block-indent:0; text-indent:0px;"><br>
and the default be ComplexAnimationEffects ?<br>
<meta name="qrichtext" content="1">
</p>
<p style="-qt-paragraph-type:empty; margin-top:0px;
margin-bottom:0px; margin-left:0px; margin-right:0px;
-qt-block-indent:0; text-indent:0px;">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<style type="text/css">
p, li { white-space: pre-wrap; </style><br>
<!--EndFragment--></p>
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<style type="text/css">
p, li { white-space: pre-wrap; }
</style><br>
<blockquote cite="mid:6880199.lxvCCEqPCt@eriador" type="cite">
<pre wrap="">
Greetings,
Dominik
</pre>
</blockquote>
<br>
</body>
</html>