<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 01/05/2014 09:42 AM, Martin
Graesslin wrote:<br>
</div>
<blockquote cite="mid:1546316.YRf7ScPhdh@martin-thinkpad"
type="cite">
<pre wrap="">On Saturday 04 January 2014 20:52:43 David Faure wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Saturday 04 January 2014 20:19:43 Hugo Pereira Da Costa wrote:
</pre>
<blockquote type="cite">
<pre wrap="">The first problem is that with kf5, the style configuration kcm expects
a libkstyle_oxygen_config.so *plugin* for this configuration, whereas it
was "kstyle_oxygen_config.so" in kde4 times.
now, as the error message indicates: plugins should not start with "lib"
and thus, oxygen still installs kstyle_oxygen_config.so only
so that the ill-named plugin is not found, and you get the error dialog.
To fix,
- either we fix the kcm by changing the looked for plugin name (by
removing the lib prefix)
</pre>
</blockquote>
<pre wrap="">
Yes. Why does the kcm look for a lib prefix now? Surely there's no good
reason for that, the kde4 way was fine.
</pre>
</blockquote>
<pre wrap="">it was me who ported the kcm. I didn't change anything in that regard - at
least not knowingly. The only change in KCMStyle::styleSpecificConfig() was:
- KLibrary library(libname, KCMStyleFactory::componentData());
+ KLibrary library(libname);
Also I think to remember that it used to work when I did the port. So I rather
think it got broken by a3194a6010961c68da80a9a8aa97501fb637f4a1
</pre>
</blockquote>
This commit is the one that _removed_ the lib prefix, consistently
with what was done with kde4:<br>
(see /usr/lib64/kde4/kstyle_oxygen_config.so, and now:
$KF5/lib/plugins/kf5/kstyle_oxygen_config.so<br>
all consistent !)<br>
<br>
as I said, this commit did break the kf5 style kcm, that
(incorrectly) expects a lib prefix, and is therefore the one that
shows up by git dissect, but I think we'd rather fix the "expect a
lib prefix part" rather than revert the commit.<br>
<br>
Best,<br>
<br>
Hugo<br>
<blockquote cite="mid:1546316.YRf7ScPhdh@martin-thinkpad"
type="cite">
<pre wrap="">
Cheers
Martin</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Kde-frameworks-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Kde-frameworks-devel@kde.org">Kde-frameworks-devel@kde.org</a>
<a class="moz-txt-link-freetext" href="https://mail.kde.org/mailman/listinfo/kde-frameworks-devel">https://mail.kde.org/mailman/listinfo/kde-frameworks-devel</a>
</pre>
</blockquote>
<br>
</body>
</html>