<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114704/">https://git.reviewboard.kde.org/r/114704/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit d8ef63c5cfe1a4d77cfab2e46addec48df6e395f by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 29th, 2013, 12:41 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 29, 2013, 12:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesignerplugin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">4 commits. In reverse order:
Deprecate -n and -g options for kgendesignerplugin
The [Globals] group is a better place to set these.
Remove calls to qt5_generate_moc
kgendesignerplugin adds a #include <foo.moc> line, so automoc will do
the work for us.
Add a DefaultGroup Global option
This allows a default group to be set in the file, instead of the
command line.
Remove unused code in kgendesignerplugin
This code read entries in the .widgets file, but never actually used the
values it read.
NB: this doesn't need to go into TP1, but if I don't post these patches, I'll forget I have them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still builds fine, including the generated plugins.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KF5DesignerPluginMacros.cmake <span style="color: grey">(43fde97f0e07a9d00d79f92bee1888bf8fcbf70c)</span></li>
<li>README.md <span style="color: grey">(5d5217e432c82149db2dcdacad5fdf2b8ee46a02)</span></li>
<li>docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook <span style="color: grey">(99d424453009f756818dc9c8f3f60558b3657453)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(3e51888614358e71756774f6bbfd5d3c14921947)</span></li>
<li>src/kgendesignerplugin.cpp <span style="color: grey">(75c35d4d3aec27afe43ada35fe497857aac8e647)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114704/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>