<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114697/">https://git.reviewboard.kde.org/r/114697/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit deaa35d72fe0c6248293b5836e084fe8ade2ec0d by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 28th, 2013, 12:35 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 12:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For resourceDirs("xdgdata-apps"), we do not use
installPath("xdgdata-apps") as the fallback (which is probably a
subdirectory of CMAKE_INSTALL_PREFIX/share/applications/), but instead
use CMAKE_INSTALL_PREFIX/share/applications/ directly.
In a sensible installation, this should make no difference, because if
XDG_DATA_DIRS is set to include CMAKE_INSTALL_PREFIX/share, and that
directory contains an applications directory, the result of
installPath("xdgdata-apps") is never used. However, this will (a) act
as a bit of a safety blanket for people who set XDG_DATA_DIRS wrong and
(b) allow the tests to pass on Jenkins, which installs kde4support to
its own directory (which then does not have a share/applications
subdirectory).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The kstandarddirs unit test now passes whether or not CMAKE_INSTALL_PREFIX/share/applications exists or not.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kdecore/kstandarddirs.cpp <span style="color: grey">(f9a29cd0e1c91861afe2a47eacac2f006248af54)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114697/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>