<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114698/">https://git.reviewboard.kde.org/r/114698/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6da2ebe9231d8bc995dcd5742889a7e055ee90db by Alex Merry to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 28th, 2013, 12:39 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and David Faure.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 12:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde4support
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prevent KStandardDirsTest::testThreads producing multiple results
testThreads() calls several other tests, some of which can call QSKIP.
This means that one test can produce several SKIPs, which doesn't make
much sense. So, instead, we check the SKIP conditions in testThreads()
itself.
Remove duplicate test code
These lines exist in another test
Use data directories we install ourselves in kstandarddirs_unittests
That way, we know they will be there, even when KDEDIRS is not set
correctly or another framework changes the data files it installs.
Skip tests requiring KConfig if KDEDIRS is not set correctly
If frameworks are installed to different locations, KDEDIRS needs to be
set appropriately for KStandardDirs to work. kstandarddirs_unittest now
checks for this, and skips the relevant tests with a helpful message if
KDEDIRS is not set properly.
Skip tests that require kde4support to be installed if it is not
Various KStandardDirs tests depend on kde4support being installed (since
KStandardDirs is supposed to find installed things), so we cannot
sensibly run them if kde4support has not been installed yet.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests pass (or at least skip with a helpful message) when kde4support is not installed, or installed to its own prefix with KDEDIRS set or unset (or set to only include the kde4support directory, or only the rest of the frameworks). Also still pass when kde4support is installed to the same prefix as the other frameworks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kstandarddirstest.h <span style="color: grey">(fb1058d9a9e7440a8aa012ed0da86f40ae3ad01e)</span></li>
<li>autotests/kstandarddirstest.cpp <span style="color: grey">(5e0151b1cf7afe344d5339031bca77405ebeb3a5)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(1529d0a33d9b80a6e5f937783ee7b8a0145d284a)</span></li>
<li>src/config-kstandarddirs.h.cmake <span style="color: grey">(40994a9af1675af2a0edb89cdd95352e84227f73)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114698/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>