<div dir="ltr">On Tue, Dec 17, 2013 at 10:59 PM, David Faure <span dir="ltr"><<a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="im">On Tuesday 17 December 2013 21:40:48 Ben Cooksley wrote:<br>
> On Tue, Dec 17, 2013 at 9:37 PM, David Faure <<a href="mailto:faure@kde.org">faure@kde.org</a>> wrote:<br>
> > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote:<br>
> > > I do have some reservations as to the name of quite a few of those<br>
> > > repositories however as they are very generic - and thus tread on common<br>
> > > namespace. Suggestions are welcome.<br>
> ><br>
> > In case anyone wonders, here's the full list of frameworks:<br>
> ><br>
> > apidox kauth kconfigwidgets kded kf5umbrella<br>
> > kiconthemes kjs kparts ktextwidgets sonnet<br>
> > dnssd kbookmarks kcoreaddons kdesu<br>
> > kfileaudiopreview kidletime kjsembed kplotting<br>
> > kunitconversion threadweaver<br>
> > frameworkintegration kcmutils kcrash kdewebkit<br>
> > kglobalaccel<br>
> > kimageformats kmediaplayer kprintutils kwallet xmlgui<br>
> > itemmodels kcodecs kdbusaddons kdewidgets kguiaddons<br>
> > kinit knewstuff kpty kwidgetsaddons<br>
> > itemviews kcompletion kde4support kdoctools khtml<br>
> > kio knotifications kross kwindowsystem<br>
> > karchive kconfig kdeclarative kemoticons ki18n<br>
> > kjobwidgets knotifyconfig kservice solid<br>
<br>
</div>Did we really mean for apidox to be a framework?<br>
<br>
Other than that, it's not too bad, is it?</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Only very few don't start with a k, and those who don't, map to the actual<br>
brand name of the framework (ThreadWeaver, Sollid). </blockquote><div><br></div><div>Other than apidox, I was also concerned about frameworkintegration, itemmodels, itemviews and dnssd. The rest of the names are quite descriptive as to what they contain and are fine.</div>
<div><br></div><div style>It isn't the lack of starting with a k which bothers me - but more the claim to a generic name. KPty, KArchive, KConfig all stand on their own - itemmodels doesn't really...</div><div style>
<br></div><div style>kde4support is also problematic as it is very similar to kdesupport and could become confused with it. kf5umbrella also seemed a little odd...</div><div style><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="im"><br>
> > > There is one exception to the above naming scheme, KWallet - as the<br>
> > > "kwallet" repository already exists it has been called<br>
> > > "kwallet-framework" instead.<br>
> ><br>
> > We should probably merge these two repos together....<br>
><br>
> I see. The current KWallet repository exists as part of kdeutils, so that<br>
> will be a little difficult in the interim.<br>
<br>
</div>Can someone else help with that? I think this requires clever usage of git<br>
filter-branch, which I don't know anything about.<br>
<div class="im"><br>
> > > Also, the following frameworks could not be pushed due to audit (EOL)<br>
> > > failures, something which shouldn't exist in final code:<br>
> > > - kde4support<br>
> > > - kdoctools<br>
> > > - kjsembed<br>
> ><br>
> > What's the plan? Shall I include support for fixing that in the splitting<br>
> > script, and we re-run it for these?<br>
><br>
> That would be a good idea, alternately one could fix it in commits made to<br>
> kdelibs prior to the split. Either would work I imagine, depends on what<br>
> makes it easier for the Git graft I guess.<br>
<br>
</div>Ah, that means re-splitting everything, so it conflicts with the last issue in<br>
this email (pushing onto the existing repos). OK, let's fix one thing at a<br>
time then.<br>
<br>
Do you have the error messages for these 3 repos? Or how can I find out where<br>
the EOL problems are? (`file` doesn't help much with C++ code).<br>
<br>
Is it missing EOL at EOF, or CRLF/LF mixup? I assumed the latter but<br>
flip -u **/*.cpp **/*.h doesn't make any changes...<br></blockquote><div><br></div><div style>It was a CRLF/LF issue - the hooks don't check for EOL at EOF.</div><div style>Output is at <a href="http://pastebin.kde.org/ppl8uu2bt">http://pastebin.kde.org/ppl8uu2bt</a></div>
<div style><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="im"><br>
> > > Everything else went fine as far as I can tell, although it wasn't<br>
> > > possible to see if the astyle tools ran or not.<br>
> ><br>
> > It didn't. Can I run it and push to the frameworks repos?<br>
><br>
> I've granted you force push powers to the frameworks repos. The commit<br>
> notification hooks should still be off for them.<br>
<br>
</div>Thanks, I'll do that later then, after the re-splitting.<br></blockquote><div><br></div><div style>Oki.</div><div style> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
--<br>
David Faure, <a href="mailto:faure@kde.org">faure@kde.org</a>, <a href="http://www.davidfaure.fr" target="_blank">http://www.davidfaure.fr</a><br>
Working on KDE, in particular KDE Frameworks 5<br>
<br>
</div></div></blockquote></div><br></div><div class="gmail_extra" style>Thanks,</div><div class="gmail_extra" style>Ben</div></div>