<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114518/">http://git.reviewboard.kde.org/r/114518/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2013, 5:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename the itemmodels frameworks to kitemmodels, as "itemmodels" is considered too generic.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">built kdelibs. I expect some breakage downstream though.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>KDE5PORTING.html <span style="color: grey">(a727079)</span></li>
<li>superbuild/CMakeLists.txt <span style="color: grey">(146d34c)</span></li>
<li>tier1/CMakeLists.txt <span style="color: grey">(b23e8ea)</span></li>
<li>tier1/itemmodels/CMakeLists.txt <span style="color: grey">(60105fc)</span></li>
<li>tier1/itemmodels/COPYING.LIB <span style="color: grey">()</span></li>
<li>tier1/itemmodels/KF5ItemModelsConfig.cmake.in <span style="color: grey">()</span></li>
<li>tier1/itemmodels/Mainpage.dox <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/CMakeLists.txt <span style="color: grey">(8beb0bf)</span></li>
<li>tier1/itemmodels/autotests/bihash/CMakeLists.txt <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/bihash/aggregrator.xls <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/bihash/benchmarker.py <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/bihash/benchmarks.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/bihash/functionalitytest.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/bihash/script.py <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/kdescendantentitiesproxymodeltest.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/kdescendantsproxymodeltest.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/klinkitemselectionmodeltest.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/klinkitemselectionmodeltest.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/kselectionproxymodeltest.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/kselectionproxymodeltestsuite.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/kselectionproxymodeltestsuite.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbdirectionwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbnavigationwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/breadcrumbswidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/checkablewidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/descendantpmwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/kidentityproxymodelwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/kreparentingproxymodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/lessthanwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/main.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/mainwindow.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/matchcheckingwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/modelcommanderwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/proxyitemselectionwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/proxymodeltestwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/recursivefilterpmwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/reparenting1.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/reparenting2.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/reparenting3.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/reparentingpmwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/scriptablereparentingwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/selectionpmwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/statesaverwidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/CMakeLists.txt <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreemodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/dynamictreewidget.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/eventlogger.qrc <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregister.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/eventloggerregister.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/grantlee_paths.h.cmake <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/indexfinder.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modelcommander.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modelcommander.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modeldumper.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modeldumper.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modeleventlogger.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modeleventlogger.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modelselector.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modelselector.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modelspy.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modelspy.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modeltest.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/modeltest.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/persistentchangelist.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/proxymodeltest.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/proxymodeltest.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/templates/datachanged.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/templates/init.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/templates/layoutchanged.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/templates/main.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/templates/modelreset.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/templates/rowsinserted.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestsuite/templates/rowsremoved.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/autotests/testmodelqueuedconnections.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/descendantentitiesproxymodel-colfilter.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/descendantentitiesproxymodel-withansecnames.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/descendantentitiesproxymodel.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/entitytreemodel-collections.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/entitytreemodel-showroot.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/entitytreemodel-showrootwithname.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/entitytreemodel.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/kbreadcrumbselectionmodel.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/kcheckableproxymodel.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/kproxyitemselectionmodel-complex.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/kproxyitemselectionmodel-error.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/kproxyitemselectionmodel-simple.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/kproxyitemselectionmodel-solution.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/kselectionproxymodel-testapp.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/mailmodelapp.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/selectionproxymodel-ordered.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/selectionproxymodelmultipleselection-withdescendant.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/selectionproxymodelmultipleselection.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/selectionproxymodelsimpleselection.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/treeandlistapp.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/dox/treeandlistappwithdesclist.png <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/CMakeLists.txt <span style="color: grey">(7e4932b)</span></li>
<li>tier1/itemmodels/src/kbihash_p.h <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/kbreadcrumbselectionmodel.h <span style="color: grey">(8bf73e9)</span></li>
<li>tier1/itemmodels/src/kbreadcrumbselectionmodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/kcheckableproxymodel.h <span style="color: grey">(3dcbd00)</span></li>
<li>tier1/itemmodels/src/kcheckableproxymodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/kdescendantsproxymodel.h <span style="color: grey">(268a982)</span></li>
<li>tier1/itemmodels/src/kdescendantsproxymodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/klinkitemselectionmodel.h <span style="color: grey">(bcb2717)</span></li>
<li>tier1/itemmodels/src/klinkitemselectionmodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/kmodelindexproxymapper.h <span style="color: grey">(72ddb80)</span></li>
<li>tier1/itemmodels/src/kmodelindexproxymapper.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/krecursivefilterproxymodel.h <span style="color: grey">(f9dc3bf)</span></li>
<li>tier1/itemmodels/src/krecursivefilterproxymodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/kselectionproxymodel.h <span style="color: grey">(0ad752f)</span></li>
<li>tier1/itemmodels/src/kselectionproxymodel.cpp <span style="color: grey">()</span></li>
<li>tier1/itemmodels/src/kvoidpointerfactory_p.h <span style="color: grey">()</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114518/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>