<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114521/">http://git.reviewboard.kde.org/r/114521/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 4a5546b1c57126f8e60cb124e31fe8e485917604 by Aurélien Gâteau to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 17th, 2013, 6:11 p.m. UTC, Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated Dec. 17, 2013, 6:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Similar to the rename of the itemmodels framework to kitemmodels. The mdns part of the code was actually broken, and has been so for quite some time now. Might be worth evaluating whether we want to drop it to simplify maintenance (would have the nice side effect of making KDNSSD a tier1 framework).
Since the DBus name has changed, a fix is needed in kde-runtime[frameworks]. Will do so when this patch is in.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built kdelibs once with Avahi and once with mdns.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>superbuild/CMakeLists.txt <span style="color: grey">(14b6904)</span></li>
<li>tier2/CMakeLists.txt <span style="color: grey">(aecb4c1)</span></li>
<li>tier2/dnssd/CMakeLists.txt <span style="color: grey">(eafc94b)</span></li>
<li>tier2/dnssd/COPYING.LIB <span style="color: grey">()</span></li>
<li>tier2/dnssd/ConfigureChecks.cmake <span style="color: grey">()</span></li>
<li>tier2/dnssd/KF5DNSSDConfig.cmake.in <span style="color: grey">()</span></li>
<li>tier2/dnssd/Mainpage.dox <span style="color: grey">(1686164)</span></li>
<li>tier2/dnssd/PACKAGERS <span style="color: grey">()</span></li>
<li>tier2/dnssd/cmake/FindAvahi.cmake <span style="color: grey">()</span></li>
<li>tier2/dnssd/cmake/FindDNSSD.cmake <span style="color: grey">()</span></li>
<li>tier2/dnssd/config-dnssd.h.cmake <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/CMakeLists.txt <span style="color: grey">(301f452)</span></li>
<li>tier2/dnssd/src/avahi-domainbrowser.cpp <span style="color: grey">(8690671)</span></li>
<li>tier2/dnssd/src/avahi-domainbrowser_p.h <span style="color: grey">(1bf895c)</span></li>
<li>tier2/dnssd/src/avahi-publicservice.cpp <span style="color: grey">(b3306f7)</span></li>
<li>tier2/dnssd/src/avahi-publicservice_p.h <span style="color: grey">(aa4efbd)</span></li>
<li>tier2/dnssd/src/avahi-remoteservice.cpp <span style="color: grey">(f039054)</span></li>
<li>tier2/dnssd/src/avahi-remoteservice_p.h <span style="color: grey">(0b25d60)</span></li>
<li>tier2/dnssd/src/avahi-servicebrowser.cpp <span style="color: grey">(a2951ed)</span></li>
<li>tier2/dnssd/src/avahi-servicebrowser_p.h <span style="color: grey">(2611b26)</span></li>
<li>tier2/dnssd/src/avahi-servicetypebrowser.cpp <span style="color: grey">(a694dd0)</span></li>
<li>tier2/dnssd/src/avahi-servicetypebrowser_p.h <span style="color: grey">(97cd50d)</span></li>
<li>tier2/dnssd/src/avahi_entrygroup_interface.h <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/avahi_entrygroup_interface.cpp <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/avahi_server_interface.h <span style="color: grey">(f6955b1)</span></li>
<li>tier2/dnssd/src/avahi_server_interface.cpp <span style="color: grey">(7a6fa92)</span></li>
<li>tier2/dnssd/src/avahi_serviceresolver_interface.h <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/avahi_serviceresolver_interface.cpp <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/domainbrowser.h <span style="color: grey">(901a936)</span></li>
<li>tier2/dnssd/src/domainmodel.h <span style="color: grey">(b7cfbe5)</span></li>
<li>tier2/dnssd/src/domainmodel.cpp <span style="color: grey">(1bea715)</span></li>
<li>tier2/dnssd/src/dummy-domainbrowser.cpp <span style="color: grey">(a41bb2e)</span></li>
<li>tier2/dnssd/src/dummy-publicservice.cpp <span style="color: grey">(d3135a4)</span></li>
<li>tier2/dnssd/src/dummy-remoteservice.cpp <span style="color: grey">(22eb623)</span></li>
<li>tier2/dnssd/src/dummy-servicebrowser.cpp <span style="color: grey">(260c1ff)</span></li>
<li>tier2/dnssd/src/dummy-servicetypebrowser.cpp <span style="color: grey">(18895cb)</span></li>
<li>tier2/dnssd/src/kcm_kdnssd.kcfg <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/mdnsd-domainbrowser.cpp <span style="color: grey">(c3c2032)</span></li>
<li>tier2/dnssd/src/mdnsd-domainbrowser_p.h <span style="color: grey">(f7e1754)</span></li>
<li>tier2/dnssd/src/mdnsd-publicservice.cpp <span style="color: grey">(96f8db2)</span></li>
<li>tier2/dnssd/src/mdnsd-remoteservice.cpp <span style="color: grey">(3efaead)</span></li>
<li>tier2/dnssd/src/mdnsd-responder.h <span style="color: grey">(b944cce)</span></li>
<li>tier2/dnssd/src/mdnsd-responder.cpp <span style="color: grey">(9c0bc45)</span></li>
<li>tier2/dnssd/src/mdnsd-sdevent.h <span style="color: grey">(d20b0de)</span></li>
<li>tier2/dnssd/src/mdnsd-servicebrowser.cpp <span style="color: grey">(a17694a)</span></li>
<li>tier2/dnssd/src/mdnsd-servicebrowser_p.h <span style="color: grey">(9d31c3a)</span></li>
<li>tier2/dnssd/src/mdnsd-servicetypebrowser.cpp <span style="color: grey">(2ac3f7f)</span></li>
<li>tier2/dnssd/src/mdnsd-servicetypebrowser_p.h <span style="color: grey">(9289588)</span></li>
<li>tier2/dnssd/src/org.freedesktop.Avahi.DomainBrowser.xml <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/org.freedesktop.Avahi.ServiceBrowser.xml <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/org.freedesktop.Avahi.ServiceTypeBrowser.xml <span style="color: grey">()</span></li>
<li>tier2/dnssd/src/publicservice.h <span style="color: grey">(6232f1b)</span></li>
<li>tier2/dnssd/src/remoteservice.h <span style="color: grey">(35edac8)</span></li>
<li>tier2/dnssd/src/servicebase.h <span style="color: grey">(3c487b0)</span></li>
<li>tier2/dnssd/src/servicebase.cpp <span style="color: grey">(9ddfdf5)</span></li>
<li>tier2/dnssd/src/servicebase_p.h <span style="color: grey">(066c35e)</span></li>
<li>tier2/dnssd/src/servicebrowser.h <span style="color: grey">(0a28e42)</span></li>
<li>tier2/dnssd/src/servicemodel.h <span style="color: grey">(4812831)</span></li>
<li>tier2/dnssd/src/servicemodel.cpp <span style="color: grey">(f3de566)</span></li>
<li>tier2/dnssd/src/servicetypebrowser.h <span style="color: grey">(b5a2452)</span></li>
<li>tier2/dnssd/src/settings.kcfgc <span style="color: grey">(01a31f0)</span></li>
<li>tier4/kde4support/src/includes/CMakeLists.txt <span style="color: grey">(710cfa9)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/Configuration <span style="color: grey">(afafd3d)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/DomainBrowser <span style="color: grey">(f2b9a9a)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/DomainModel <span style="color: grey">(63d1a21)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/PublicService <span style="color: grey">(4f665f1)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/RemoteService <span style="color: grey">(1e0dc06)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/ServiceBase <span style="color: grey">(dc40c19)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/ServiceBrowser <span style="color: grey">(221e9e9)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/ServiceModel <span style="color: grey">(cd07f94)</span></li>
<li>tier4/kde4support/src/includes/DNSSD/ServiceTypeBrowser <span style="color: grey">(03e384f)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/Configuration <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/DomainBrowser <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/DomainModel <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/PublicService <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/RemoteService <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/ServiceBase <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/ServiceBrowser <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/ServiceModel <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/kde4support/src/includes/KDNSSD/ServiceTypeBrowser <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114521/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>