<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114496/">http://git.reviewboard.kde.org/r/114496/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should go in before the split, since it affects the name of one of the splitted frameworks.

If everyone is OK with the naming, I'll push this before the re-splitting.</pre>
 <br />









<p>- David Faure</p>


<br />
<p>On December 16th, 2013, 9:06 p.m. UTC, Alex Merry wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Alex Merry.</div>


<p style="color: grey;"><i>Updated Dec. 16, 2013, 9:06 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename kdewidgets to kf5designerplugin

This includes renaming makekdewidgets to kgendesignerplugin.


Just throwing this at reviewboard before I dash for a train.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMake runs, nothing else tested.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>superbuild/CMakeLists.txt <span style="color: grey">(b53cae64698562588f39ed28b2f30bf0a1f46809)</span></li>

 <li>tier3/CMakeLists.txt <span style="color: grey">(374396b3909d5a71dff6d891249ab33194a45522)</span></li>

 <li>tier3/kdesignerplugin/KF5DesignerPluginConfig.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier3/kdesignerplugin/Mainpage.dox <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier3/kdesignerplugin/docs/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier3/kdesignerplugin/docs/kgendesignerplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier3/kdesignerplugin/docs/kgendesignerplugin/man-kgendesignerplugin.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier3/kdesignerplugin/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier3/kdesignerplugin/tests/README <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tier3/kdewidgets/CMakeLists.txt <span style="color: grey">(87c3d5484dfb86018cdd203807588ea6ebd6ac31)</span></li>

 <li>tier3/kdewidgets/KDEWidgetsConfig.cmake <span style="color: grey">(d38c875c67a3073e7634bd6f873a38411127b759)</span></li>

 <li>tier3/kdewidgets/KDEWidgetsMacros.cmake <span style="color: grey">(92d2960a7dfe1645d7c75e3dc6690d78b50706d8)</span></li>

 <li>tier3/kdewidgets/Mainpage.dox <span style="color: grey">(85da237c9d4367a37b9b0750565d42e1e73d1ba4)</span></li>

 <li>tier3/kdewidgets/docs/CMakeLists.txt <span style="color: grey">(2b38f53f807c528fdcd6ea128567f6087bd8c673)</span></li>

 <li>tier3/kdewidgets/docs/makekdewidgets/CMakeLists.txt <span style="color: grey">(c283b926f542402d80e22cc42406b119e400a05f)</span></li>

 <li>tier3/kdewidgets/docs/makekdewidgets/man-makekdewidgets.1.docbook <span style="color: grey">(cab0c5b51f2bb5be29960f43fe6fb940fffb5402)</span></li>

 <li>tier3/kdewidgets/src/AUTHORS <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/CMakeLists.txt <span style="color: grey">(e8626c84227a2ccd0459c5732a51e9ecea49f699)</span></li>

 <li>tier3/kdewidgets/src/README <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/classpreviews.h <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/classpreviews.cpp <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/kde.widgets <span style="color: grey">(7bcc669d14ed40da6217d09296e25d60a59413b7)</span></li>

 <li>tier3/kdewidgets/src/kdewebkit.widgets <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/kdewebkitwidgets.qrc <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/kdewidgets.qrc <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/makekdewidgets.cpp <span style="color: grey">(d20e49956a939a06fe3bc2280d57c5c6d31fe24c)</span></li>

 <li>tier3/kdewidgets/src/pics/CMakeLists.txt <span style="color: grey">(688224a6a1ca9f68b7e7f918fa6b8aee3dbe6180)</span></li>

 <li>tier3/kdewidgets/src/pics/k3iconview.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/k3listview.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kactionselector.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kactivelabel.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kcharselect.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kcmodule.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kcolorbutton.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kcolorcombo.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kcombobox.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kdatepicker.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kdatetable.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kdualcolorbutton.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/keditlistwidget.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kfontcombo.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kfontrequester.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kgradientselector.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/khistorycombo.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/khsselector.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kiconbutton.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kkeybutton.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kled.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/klineedit.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/klistbox.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kpalettetable.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kpasswordedit.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kruler.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/ksqueezedtextlabel.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/ktextedit.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kurlcomborequester.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kurllabel.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/src/pics/kurlrequester.png <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/tests/CMakeLists.txt <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/tests/README <span style="color: grey">(9dd2132fa7c3601ae04f243a5996aa809b42f7bf)</span></li>

 <li>tier3/kdewidgets/tests/sums <span style="color: grey">()</span></li>

 <li>tier3/kdewidgets/tests/test.widgets <span style="color: grey">()</span></li>

 <li>tier4/kde4support/CMakeLists.txt <span style="color: grey">(ccbffd24ede13d5ae6d8386a4aac1853018fcc97)</span></li>

 <li>tier4/kde4support/cmake/modules/KDE4Macros.cmake <span style="color: grey">(ddfd374607d0eef436fdd6c9e408cd98e59181ae)</span></li>

 <li>tier4/kde4support/src/CMakeLists.txt <span style="color: grey">(467e8378e555139774924f053b477050ebba9f5c)</span></li>

 <li>tier4/kde4support/src/KDEUIMacros.cmake <span style="color: grey">(31a180c1aab14f22e6a157e8aabfa901db15081a)</span></li>

 <li>tier4/kde4support/src/kdedeprecated.widgets <span style="color: grey">(604358ac69ba8a8cfbdd8b41a796405fdddebd12)</span></li>

 <li>tier4/kde4support/src/pics/CMakeLists.txt <span style="color: grey">(c0e1c2064af67e9ad90d8f5e8a9c892208c6cda0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114496/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>