<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114394/">http://git.reviewboard.kde.org/r/114394/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Kevin Ottens</p>
<br />
<p>On December 10th, 2013, 10:24 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Albert Astals Cid.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2013, 10:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Replacement for https://git.reviewboard.kde.org/r/114187/; done as two commits. The first is John's original patch, with him listed as the commit author. The second is my modifications.
Hopefully this will be flexible enough for translators. See the "if this does not fit the grammar of your language" comments for possible problem points.
Added Albert, as I would appreciate the view of someone knowledgable about i18n.
-------------------------------------
KLocale offers a number of extra formatting options not yet available
in Qt. The KFormat class adds these options to KCoreAddons:
* formatByteSize()
* formatDuration()
* formatDecimalDuration()
* formatSpelloutDuration()
* formatRelativeDate()
* formatRelativeDateTime()
The KFormat class can be initialised with any QLocale to use in the
date and number formatting, or the default locale can be easily
accessed via KFormat():
QString result = KFormat().formatDuration(1000);</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Autotests pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/kcoreaddons/autotests/CMakeLists.txt <span style="color: grey">(c8043576181e7d06663195d017be930d0bdcbde9)</span></li>
<li>tier1/kcoreaddons/autotests/kformattest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kcoreaddons/autotests/kformattest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kcoreaddons/src/lib/CMakeLists.txt <span style="color: grey">(638525f7b719bcd0bc1dfdf94debd51296521334)</span></li>
<li>tier1/kcoreaddons/src/lib/util/kformat.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kcoreaddons/src/lib/util/kformat.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kcoreaddons/src/lib/util/kformatprivate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kcoreaddons/src/lib/util/kformatprivate_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114394/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>