<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114363/">http://git.reviewboard.kde.org/r/114363/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit e8339bcbeb6aa28a9c5899d0b6c23c3e1373ab51 by Martin Klapetek to branch lib_prefix.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 9th, 2013, 2:05 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2013, 2:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tier3 updated with KF5 prefix.
Not updated:
KCMUtils (given that KCM is used all around KDE, I'd leave this one?)
KDED (same as KCMUtils imho)
KDEWebkit (should it be KF5WebKit?)
KDEWidgets (KF5Widgets?)
KIO (discussed to stay KIO)
Kross (KF5Kross?)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Things build (with CMakeLists changes, obviously).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier3/kbookmarks/CMakeLists.txt <span style="color: grey">(5866b2f)</span></li>
<li>tier3/kbookmarks/KBookmarksConfig.cmake.in <span style="color: grey">(06b0b9e)</span></li>
<li>tier3/kbookmarks/KF5BookmarksConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kbookmarks/autotests/CMakeLists.txt <span style="color: grey">(c902f98)</span></li>
<li>tier3/kbookmarks/src/CMakeLists.txt <span style="color: grey">(37c27a6)</span></li>
<li>tier3/kbookmarks/tests/CMakeLists.txt <span style="color: grey">(cadebb9)</span></li>
<li>tier3/kconfigwidgets/CMakeLists.txt <span style="color: grey">(56c9edc)</span></li>
<li>tier3/kconfigwidgets/KConfigWidgetsConfig.cmake.in <span style="color: grey">(5197878)</span></li>
<li>tier3/kconfigwidgets/KF5ConfigWidgetsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kconfigwidgets/autotests/CMakeLists.txt <span style="color: grey">(363658c)</span></li>
<li>tier3/kconfigwidgets/src/CMakeLists.txt <span style="color: grey">(b8bd464)</span></li>
<li>tier3/kconfigwidgets/tests/CMakeLists.txt <span style="color: grey">(7d7d6d6)</span></li>
<li>tier3/kdeclarative/CMakeLists.txt <span style="color: grey">(67eb43d)</span></li>
<li>tier3/kdeclarative/KDeclarativeConfig.cmake.in <span style="color: grey">(27c51ad)</span></li>
<li>tier3/kdeclarative/KF5DeclarativeConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kdeclarative/src/CMakeLists.txt <span style="color: grey">(ac5e9f9)</span></li>
<li>tier3/kdeclarative/tests/CMakeLists.txt <span style="color: grey">(c5391c9)</span></li>
<li>tier3/kdesu/CMakeLists.txt <span style="color: grey">(50f98eb)</span></li>
<li>tier3/kdesu/KDESuConfig.cmake.in <span style="color: grey">(e1b4c92)</span></li>
<li>tier3/kdesu/KF5SuConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kdesu/src/CMakeLists.txt <span style="color: grey">(a96ae54)</span></li>
<li>tier3/kemoticons/CMakeLists.txt <span style="color: grey">(d0eb51b)</span></li>
<li>tier3/kemoticons/KEmoticonsConfig.cmake.in <span style="color: grey">(a26202f)</span></li>
<li>tier3/kemoticons/KF5EmoticonsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kemoticons/src/core/CMakeLists.txt <span style="color: grey">(dc64aa0)</span></li>
<li>tier3/kemoticons/src/providers/adium/CMakeLists.txt <span style="color: grey">(50ccbb3)</span></li>
<li>tier3/kemoticons/src/providers/kde/CMakeLists.txt <span style="color: grey">(362581c)</span></li>
<li>tier3/kemoticons/src/providers/pidgin/CMakeLists.txt <span style="color: grey">(db44c30)</span></li>
<li>tier3/kemoticons/src/providers/xmpp/CMakeLists.txt <span style="color: grey">(4d86f79)</span></li>
<li>tier3/kemoticons/tests/CMakeLists.txt <span style="color: grey">(9324d4e)</span></li>
<li>tier3/kiconthemes/CMakeLists.txt <span style="color: grey">(d1191d1)</span></li>
<li>tier3/kiconthemes/KF5IconThemesConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kiconthemes/KIconThemesConfig.cmake.in <span style="color: grey">(a67a259)</span></li>
<li>tier3/kiconthemes/autotests/CMakeLists.txt <span style="color: grey">(2ee90c9)</span></li>
<li>tier3/kiconthemes/src/CMakeLists.txt <span style="color: grey">(f900c6c)</span></li>
<li>tier3/kiconthemes/tests/CMakeLists.txt <span style="color: grey">(77a543c)</span></li>
<li>tier3/kinit/CMakeLists.txt <span style="color: grey">(7943efb)</span></li>
<li>tier3/kinit/KF5InitConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kinit/KF5InitMacros.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kinit/KInitConfig.cmake.in <span style="color: grey">(4b992bb)</span></li>
<li>tier3/kinit/KInitMacros.cmake <span style="color: grey">(e8212bb)</span></li>
<li>tier3/kinit/src/CMakeLists.txt <span style="color: grey">(451f344)</span></li>
<li>tier3/kjsembed/CMakeLists.txt <span style="color: grey">(f80510f)</span></li>
<li>tier3/kjsembed/KF5JsEmbedConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kjsembed/KJsEmbedConfig.cmake.in <span style="color: grey">(f976d0f)</span></li>
<li>tier3/kjsembed/examples/kjsconsole/CMakeLists.txt <span style="color: grey">(85e79c6)</span></li>
<li>tier3/kjsembed/src/kjscmd/CMakeLists.txt <span style="color: grey">(fde0c6f)</span></li>
<li>tier3/kjsembed/src/kjsembed/CMakeLists.txt <span style="color: grey">(f883f19)</span></li>
<li>tier3/kmediaplayer/CMakeLists.txt <span style="color: grey">(54949a1)</span></li>
<li>tier3/kmediaplayer/KF5MediaPlayerConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kmediaplayer/KMediaPlayerConfig.cmake.in <span style="color: grey">(de5e7f8)</span></li>
<li>tier3/kmediaplayer/autotests/CMakeLists.txt <span style="color: grey">(59664a1)</span></li>
<li>tier3/kmediaplayer/src/kmediaplayer/CMakeLists.txt <span style="color: grey">(d9cc93d)</span></li>
<li>tier3/knewstuff/CMakeLists.txt <span style="color: grey">(faaa976)</span></li>
<li>tier3/knewstuff/KF5NewStuffConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/knewstuff/KNewStuffConfig.cmake.in <span style="color: grey">(92dfe90)</span></li>
<li>tier3/knewstuff/src/CMakeLists.txt <span style="color: grey">(b7c94a8)</span></li>
<li>tier3/knotifyconfig/CMakeLists.txt <span style="color: grey">(16c147c)</span></li>
<li>tier3/knotifyconfig/KF5NotifyConfigConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/knotifyconfig/KNotifyConfigConfig.cmake.in <span style="color: grey">(349afa5)</span></li>
<li>tier3/knotifyconfig/src/CMakeLists.txt <span style="color: grey">(35369eb)</span></li>
<li>tier3/knotifyconfig/tests/CMakeLists.txt <span style="color: grey">(35011a6)</span></li>
<li>tier3/kparts/KF5PartsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kparts/KPartsConfig.cmake.in <span style="color: grey">(da45a40)</span></li>
<li>tier3/kparts/autotests/CMakeLists.txt <span style="color: grey">(340f2f1)</span></li>
<li>tier3/kparts/src/CMakeLists.txt <span style="color: grey">(ecfeab4)</span></li>
<li>tier3/kparts/tests/CMakeLists.txt <span style="color: grey">(9ed2dc8)</span></li>
<li>tier3/kprintutils/CMakeLists.txt <span style="color: grey">(cbacbb6)</span></li>
<li>tier3/kprintutils/KF5PrintUtilsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kprintutils/KPrintUtilsConfig.cmake.in <span style="color: grey">(a1eba9a)</span></li>
<li>tier3/kprintutils/src/CMakeLists.txt <span style="color: grey">(c6af604)</span></li>
<li>tier3/kprintutils/tests/CMakeLists.txt <span style="color: grey">(8f40671)</span></li>
<li>tier3/kpty/CMakeLists.txt <span style="color: grey">(fc28e03)</span></li>
<li>tier3/kpty/KF5PtyConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kpty/KPtyConfig.cmake.in <span style="color: grey">(4a948c5)</span></li>
<li>tier3/kpty/autotests/CMakeLists.txt <span style="color: grey">(4f0a164)</span></li>
<li>tier3/kpty/src/CMakeLists.txt <span style="color: grey">(add6aa4)</span></li>
<li>tier3/kservice/CMakeLists.txt <span style="color: grey">(a329529)</span></li>
<li>tier3/kservice/KF5ServiceConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kservice/KF5ServiceMacros.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kservice/KServiceConfig.cmake.in <span style="color: grey">(43dda48)</span></li>
<li>tier3/kservice/KServiceMacros.cmake <span style="color: grey">(694b899)</span></li>
<li>tier3/kservice/src/CMakeLists.txt <span style="color: grey">(cc0c1a4)</span></li>
<li>tier3/kservice/src/desktoptojson/CMakeLists.txt <span style="color: grey">(afe21f2)</span></li>
<li>tier3/kservice/src/kbuildsycoca/CMakeLists.txt <span style="color: grey">(3a82b79)</span></li>
<li>tier3/kservice/tests/CMakeLists.txt <span style="color: grey">(9c89ceb)</span></li>
<li>tier3/kservice/tests/kservicetojsontest/CMakeLists.txt <span style="color: grey">(cc559d8)</span></li>
<li>tier3/kservice/tests/pluginlocator/CMakeLists.txt <span style="color: grey">(be6d477)</span></li>
<li>tier3/ktextwidgets/CMakeLists.txt <span style="color: grey">(0014315)</span></li>
<li>tier3/ktextwidgets/KF5TextWidgetsConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/ktextwidgets/KTextWidgetsConfig.cmake.in <span style="color: grey">(064a8ac)</span></li>
<li>tier3/ktextwidgets/autotests/CMakeLists.txt <span style="color: grey">(9676520)</span></li>
<li>tier3/ktextwidgets/src/CMakeLists.txt <span style="color: grey">(043ec0a)</span></li>
<li>tier3/ktextwidgets/tests/CMakeLists.txt <span style="color: grey">(b26efce)</span></li>
<li>tier3/kunitconversion/CMakeLists.txt <span style="color: grey">(15bf61a)</span></li>
<li>tier3/kunitconversion/KF5UnitConversionConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/kunitconversion/KUnitConversionConfig.cmake.in <span style="color: grey">(921c342)</span></li>
<li>tier3/kunitconversion/autotests/CMakeLists.txt <span style="color: grey">(6bbb403)</span></li>
<li>tier3/kunitconversion/src/CMakeLists.txt <span style="color: grey">(b8b8e2f)</span></li>
<li>tier3/xmlgui/CMakeLists.txt <span style="color: grey">(75593fb)</span></li>
<li>tier3/xmlgui/KF5XmlGuiConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/xmlgui/XmlGuiConfig.cmake.in <span style="color: grey">(657959d)</span></li>
<li>tier3/xmlgui/autotests/CMakeLists.txt <span style="color: grey">(6546ac7)</span></li>
<li>tier3/xmlgui/src/CMakeLists.txt <span style="color: grey">(31621e2)</span></li>
<li>tier3/xmlgui/tests/CMakeLists.txt <span style="color: grey">(b756358)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>