<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114356/">http://git.reviewboard.kde.org/r/114356/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking good as far as renaming goes, three small issues below</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114356/diff/2/?file=223489#file223489line7" style="color: black; font-weight: bold; text-decoration: underline;">tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">include("${CMAKE_CURRENT_LIST_DIR}/KGlobalAccelTargets.cmake")</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This needs KF5GlobalAccelTargets.cmake --> include("${CMAKE_CURRENT_LIST_DIR}/KF5GlobalAccelTargets.cmake")</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114356/diff/2/?file=223523#file223523line45" style="color: black; font-weight: bold; text-decoration: underline;">tier4/kde4support/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">KGlobalAccel</span> <span class="o">${</span><span class="nv">KF5_VERSION</span><span class="o">}</span> <span class="s">REQUIRED</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This becomes KF5GlobalAccel</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/114356/diff/2/?file=223525#file223525line39" style="color: black; font-weight: bold; text-decoration: underline;">tier4/khtml/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">find_package</span><span class="p">(</span><span class="s">KGlobalAccel</span> <span class="o">${</span><span class="nv">KF5_VERSION</span><span class="o">}</span> <span class="s">REQUIRED</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same here</pre>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On December 9th, 2013, 2:24 p.m. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Martin Klapetek.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2013, 2:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New framework needs DBus, Widgets and (optionally) X11Extras as dependencies.
@MartinK: how should we organize the renaming? I'm still using the old naming scheme. So should I adjust or should we use your scripts after pulling this one in?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/CMakeLists.txt <span style="color: grey">(450ca57)</span></li>
<li>tier1/kglobalaccel/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/KF5GlobalAccelConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/autotests/kglobalshortcuttest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/autotests/kglobalshortcuttest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/config-kglobalaccel.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalaccel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalaccel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalaccel_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo_dbus.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/kglobalshortcutinfo_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/org.kde.KGlobalAccel.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/kglobalaccel/src/org.kde.kglobalaccel.Component.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier3/xmlgui/CMakeLists.txt <span style="color: grey">(75593fb)</span></li>
<li>tier3/xmlgui/autotests/CMakeLists.txt <span style="color: grey">(6546ac7)</span></li>
<li>tier3/xmlgui/autotests/kglobalshortcuttest.h <span style="color: grey">(d8e0024)</span></li>
<li>tier3/xmlgui/autotests/kglobalshortcuttest.cpp <span style="color: grey">(453920b)</span></li>
<li>tier3/xmlgui/src/CMakeLists.txt <span style="color: grey">(31621e2)</span></li>
<li>tier3/xmlgui/src/kactioncollection.cpp <span style="color: grey">(0266069)</span></li>
<li>tier3/xmlgui/src/kglobalaccel.h <span style="color: grey">(57482ad)</span></li>
<li>tier3/xmlgui/src/kglobalaccel.cpp <span style="color: grey">(77ce993)</span></li>
<li>tier3/xmlgui/src/kglobalaccel_p.h <span style="color: grey">(50f271f)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo.h <span style="color: grey">(0920f01)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo.cpp <span style="color: grey">(d2ca948)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo_dbus.cpp <span style="color: grey">(f49bd9d)</span></li>
<li>tier3/xmlgui/src/kglobalshortcutinfo_p.h <span style="color: grey">(dd2dd2d)</span></li>
<li>tier3/xmlgui/src/kkeysequencewidget.cpp <span style="color: grey">(2148ce0)</span></li>
<li>tier3/xmlgui/src/kshortcutseditor.cpp <span style="color: grey">(3e917d2)</span></li>
<li>tier3/xmlgui/src/kshortcutseditoritem.cpp <span style="color: grey">(e7257a6)</span></li>
<li>tier3/xmlgui/src/kxmlguifactory.cpp <span style="color: grey">(510d2ea)</span></li>
<li>tier3/xmlgui/src/org.kde.KGlobalAccel.xml <span style="color: grey">(8746551)</span></li>
<li>tier3/xmlgui/src/org.kde.kglobalaccel.Component.xml <span style="color: grey">(ec21201)</span></li>
<li>tier4/kde4support/CMakeLists.txt <span style="color: grey">(cb73b46)</span></li>
<li>tier4/kde4support/src/CMakeLists.txt <span style="color: grey">(39298b9)</span></li>
<li>tier4/khtml/CMakeLists.txt <span style="color: grey">(c937f38)</span></li>
<li>tier4/khtml/src/CMakeLists.txt <span style="color: grey">(00243fb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114356/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>