<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114182/">http://git.reviewboard.kde.org/r/114182/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 4th, 2013, 8:01 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks mostly good, but something looks wrong with the patch, I guess you moved the *Config.cmake.in files, but we see them simply deleted, as they got probably edited too (because of the target files) it'd be nice to get a more complete patch.</pre>
</blockquote>
<p>On December 5th, 2013, 2:47 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In particular, you may want to use
`git diff --find-copies-harder frameworks`
to generate the diff file.</pre>
</blockquote>
<p>On December 5th, 2013, 2:50 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried that, however the files are rather small and very similar, so it was even more confusing (as it showed several deleted files moved into one with similarity index ~55%...so I deemed it useless).</pre>
</blockquote>
<p>On December 5th, 2013, 2:59 p.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Huh. What's puzzling, though, is that while the diff shows tier1/itemmodels/ItemModelsConfig.cmake.in as being deleted, it doesn't show tier1/itemmodels/KF5ItemModelsConfig.cmake.in as being added (and similarly for the other .cmake.in files). Any idea why?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I might have forgotten to stage them. I'm preparing new patch right now so I'll fix it ;) Thanks for the notice.</pre>
<br />
<p>- Martin</p>
<br />
<p>On November 29th, 2013, 1:04 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2013, 1:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is just one framework - KConfig - if this is the proper way to do this, I'll update this review with all frameworks updated to this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/itemmodels/CMakeLists.txt <span style="color: grey">(d0be692)</span></li>
<li>tier1/itemmodels/ItemModelsConfig.cmake.in <span style="color: grey">(4ac98f3)</span></li>
<li>tier1/itemmodels/autotests/CMakeLists.txt <span style="color: grey">(03daf70)</span></li>
<li>tier1/itemmodels/autotests/proxymodeltestapp/CMakeLists.txt <span style="color: grey">(525c9f3)</span></li>
<li>tier1/itemmodels/src/CMakeLists.txt <span style="color: grey">(86b48cf)</span></li>
<li>tier1/itemviews/CMakeLists.txt <span style="color: grey">(1bdadac)</span></li>
<li>tier1/itemviews/ItemViewsConfig.cmake.in <span style="color: grey">(1956453)</span></li>
<li>tier1/itemviews/autotests/CMakeLists.txt <span style="color: grey">(0219900)</span></li>
<li>tier1/itemviews/src/CMakeLists.txt <span style="color: grey">(bad773c)</span></li>
<li>tier1/itemviews/tests/CMakeLists.txt <span style="color: grey">(4ddf5d8)</span></li>
<li>tier1/karchive/CMakeLists.txt <span style="color: grey">(f0d12ac)</span></li>
<li>tier1/karchive/KArchiveConfig.cmake.in <span style="color: grey">(40fa614)</span></li>
<li>tier1/karchive/autotests/CMakeLists.txt <span style="color: grey">(a2cfabe)</span></li>
<li>tier1/karchive/examples/helloworld/CMakeLists.txt <span style="color: grey">(2e90094)</span></li>
<li>tier1/karchive/examples/tarlocalfiles/CMakeLists.txt <span style="color: grey">(b855caf)</span></li>
<li>tier1/karchive/src/CMakeLists.txt <span style="color: grey">(767140a)</span></li>
<li>tier1/karchive/tests/CMakeLists.txt <span style="color: grey">(d804cd2)</span></li>
<li>tier1/kcodecs/CMakeLists.txt <span style="color: grey">(a8217d0)</span></li>
<li>tier1/kcodecs/KCodecsConfig.cmake.in <span style="color: grey">(ea632ce)</span></li>
<li>tier1/kcodecs/autotests/CMakeLists.txt <span style="color: grey">(bf393f8)</span></li>
<li>tier1/kcodecs/src/CMakeLists.txt <span style="color: grey">(152bc8e)</span></li>
<li>tier1/kconfig/CMakeLists.txt <span style="color: grey">(af91aa2)</span></li>
<li>tier1/kconfig/KConfigConfig.cmake.in <span style="color: grey">(5d9d7eb)</span></li>
<li>tier1/kconfig/autotests/CMakeLists.txt <span style="color: grey">(cc2626b)</span></li>
<li>tier1/kconfig/autotests/kconfig_compiler/CMakeLists.txt <span style="color: grey">(184ab17)</span></li>
<li>tier1/kconfig/src/core/CMakeLists.txt <span style="color: grey">(c8a4842)</span></li>
<li>tier1/kconfig/src/gui/CMakeLists.txt <span style="color: grey">(b677d03)</span></li>
<li>tier1/kconfig/src/kconf_update/CMakeLists.txt <span style="color: grey">(69668bc)</span></li>
<li>tier1/kconfig/src/kconfig_compiler/CMakeLists.txt <span style="color: grey">(19d86d4)</span></li>
<li>tier1/kcoreaddons/CMakeLists.txt <span style="color: grey">(5d2b4a8)</span></li>
<li>tier1/kcoreaddons/KCoreAddonsConfig.cmake.in <span style="color: grey">(a53be5f)</span></li>
<li>tier1/kcoreaddons/autotests/CMakeLists.txt <span style="color: grey">(c804357)</span></li>
<li>tier1/kcoreaddons/src/lib/CMakeLists.txt <span style="color: grey">(638525f)</span></li>
<li>tier1/kcoreaddons/tests/CMakeLists.txt <span style="color: grey">(c79d0ba)</span></li>
<li>tier1/kdbusaddons/CMakeLists.txt <span style="color: grey">(78cc443)</span></li>
<li>tier1/kdbusaddons/KDBusAddonsConfig.cmake.in <span style="color: grey">(27a6060)</span></li>
<li>tier1/kdbusaddons/autotests/CMakeLists.txt <span style="color: grey">(92c9151)</span></li>
<li>tier1/kdbusaddons/src/CMakeLists.txt <span style="color: grey">(71dc290)</span></li>
<li>tier1/kdbusaddons/tests/CMakeLists.txt <span style="color: grey">(684fee3)</span></li>
<li>tier1/kguiaddons/CMakeLists.txt <span style="color: grey">(b3f378d)</span></li>
<li>tier1/kguiaddons/KGuiAddonsConfig.cmake.in <span style="color: grey">(83e4c91)</span></li>
<li>tier1/kguiaddons/autotests/CMakeLists.txt <span style="color: grey">(2e4a6bb)</span></li>
<li>tier1/kguiaddons/src/CMakeLists.txt <span style="color: grey">(ca94f4b)</span></li>
<li>tier1/kguiaddons/tests/CMakeLists.txt <span style="color: grey">(754b460)</span></li>
<li>tier1/kidletime/CMakeLists.txt <span style="color: grey">(61ba25b)</span></li>
<li>tier1/kidletime/KIdleTimeConfig.cmake.in <span style="color: grey">(ace9e8a)</span></li>
<li>tier1/kidletime/examples/CMakeLists.txt <span style="color: grey">(c88a6c3)</span></li>
<li>tier1/kidletime/src/CMakeLists.txt <span style="color: grey">(44a1f3f)</span></li>
<li>tier1/kjs/CMakeLists.txt <span style="color: grey">(ab27a14)</span></li>
<li>tier1/kjs/KJSConfig.cmake.in <span style="color: grey">(8c4ff9e)</span></li>
<li>tier1/kjs/autotests/CMakeLists.txt <span style="color: grey">(206c17a)</span></li>
<li>tier1/kjs/src/kjs/CMakeLists.txt <span style="color: grey">(b63d92f)</span></li>
<li>tier1/kjs/src/kjs/api/CMakeLists.txt <span style="color: grey">(dadf39c)</span></li>
<li>tier1/kjs/tests/CMakeLists.txt <span style="color: grey">(9388a70)</span></li>
<li>tier1/kplotting/CMakeLists.txt <span style="color: grey">(f8e53ff)</span></li>
<li>tier1/kplotting/KPlottingConfig.cmake.in <span style="color: grey">(42d4fae)</span></li>
<li>tier1/kplotting/autotests/CMakeLists.txt <span style="color: grey">(cc03ea4)</span></li>
<li>tier1/kplotting/examples/CMakeLists.txt <span style="color: grey">(7c8ab7e)</span></li>
<li>tier1/kplotting/src/CMakeLists.txt <span style="color: grey">(59e7d09)</span></li>
<li>tier1/kwidgetsaddons/CMakeLists.txt <span style="color: grey">(570630b)</span></li>
<li>tier1/kwidgetsaddons/KWidgetsAddonsConfig.cmake.in <span style="color: grey">(98dbc46)</span></li>
<li>tier1/kwidgetsaddons/autotests/CMakeLists.txt <span style="color: grey">(1f6b69f)</span></li>
<li>tier1/kwidgetsaddons/src/CMakeLists.txt <span style="color: grey">(0333f3a)</span></li>
<li>tier1/kwidgetsaddons/tests/CMakeLists.txt <span style="color: grey">(129504b)</span></li>
<li>tier1/kwindowsystem/CMakeLists.txt <span style="color: grey">(cebdf49)</span></li>
<li>tier1/kwindowsystem/KWindowSystemConfig.cmake.in <span style="color: grey">(49308aa)</span></li>
<li>tier1/kwindowsystem/autotests/CMakeLists.txt <span style="color: grey">(92d4868)</span></li>
<li>tier1/kwindowsystem/src/CMakeLists.txt <span style="color: grey">(f6e27ee)</span></li>
<li>tier1/kwindowsystem/tests/CMakeLists.txt <span style="color: grey">(fbf3d26)</span></li>
<li>tier1/solid/CMakeLists.txt <span style="color: grey">(6676410)</span></li>
<li>tier1/solid/SolidConfig.cmake.in <span style="color: grey">(16637e9)</span></li>
<li>tier1/solid/autotests/CMakeLists.txt <span style="color: grey">(8c46a1a)</span></li>
<li>tier1/solid/src/imports/CMakeLists.txt <span style="color: grey">(ac91736)</span></li>
<li>tier1/solid/src/solid/CMakeLists.txt <span style="color: grey">(024c7fa)</span></li>
<li>tier1/solid/tests/CMakeLists.txt <span style="color: grey">(6bcf3cf)</span></li>
<li>tier1/sonnet/CMakeLists.txt <span style="color: grey">(bad6191)</span></li>
<li>tier1/sonnet/SonnetConfig.cmake.in <span style="color: grey">(13dcfe4)</span></li>
<li>tier1/sonnet/autotests/CMakeLists.txt <span style="color: grey">(c979842)</span></li>
<li>tier1/sonnet/src/core/CMakeLists.txt <span style="color: grey">(7aa41c0)</span></li>
<li>tier1/sonnet/src/plugins/aspell/CMakeLists.txt <span style="color: grey">(e2d78b8)</span></li>
<li>tier1/sonnet/src/plugins/enchant/CMakeLists.txt <span style="color: grey">(9270833)</span></li>
<li>tier1/sonnet/src/plugins/hspell/CMakeLists.txt <span style="color: grey">(b846ed4)</span></li>
<li>tier1/sonnet/src/plugins/hunspell/CMakeLists.txt <span style="color: grey">(0730284)</span></li>
<li>tier1/sonnet/src/ui/CMakeLists.txt <span style="color: grey">(2e2ef16)</span></li>
<li>tier1/sonnet/tests/CMakeLists.txt <span style="color: grey">(71d0ad6)</span></li>
<li>tier1/threadweaver/CMakeLists.txt <span style="color: grey">(61c2587)</span></li>
<li>tier1/threadweaver/ThreadWeaverConfig.cmake.in <span style="color: grey">(bc116f0c)</span></li>
<li>tier1/threadweaver/autotests/CMakeLists.txt <span style="color: grey">(9ae5b1d)</span></li>
<li>tier1/threadweaver/benchmarks/CMakeLists.txt <span style="color: grey">(07f7875)</span></li>
<li>tier1/threadweaver/src/Weaver/CMakeLists.txt <span style="color: grey">(d003e9f)</span></li>
<li>tier1/threadweaver/src/WeaverGui/CMakeLists.txt <span style="color: grey">(4c4e1b2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114182/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>