<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114256/">http://git.reviewboard.kde.org/r/114256/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 73d6a9c5e7ef319456cbdc09234179e65f9ee465 by Aleix Pol to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On December 2nd, 2013, 7:01 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2013, 7:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since I'd say it's the most important dialog, I decided to adopt it right away.
Instead of moving KFileDialog or anything, I chose to create a new dialog that just contains a KFileWidget, which is what I understand what we want in a last instance.
Everything is deeply undocumented, so if anybody has a clue about QPlatformTheme, it would be interesting if s/he could take a look.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created a test app that instantiates a QFileDialog, used a QFileDialog from systemsettings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier4/frameworkintegration/tests/CMakeLists.txt <span style="color: grey">(4ed65f8)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.cpp <span style="color: grey">(010eed4)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformtheme.h <span style="color: grey">(69f1f44)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/kdeplatformfiledialoghelper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier4/frameworkintegration/src/platformtheme/CMakeLists.txt <span style="color: grey">(5d95c8a)</span></li>
<li>tier4/frameworkintegration/autotests/CMakeLists.txt <span style="color: grey">(f126859)</span></li>
<li>tier4/frameworkintegration/CMakeLists.txt <span style="color: grey">(02b3563)</span></li>
<li>tier4/frameworkintegration/tests/qfiledialogtest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114256/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>